Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Compiler - Deprecated dsl-compile --package #1941

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 23, 2019

I does not seem that anyone is using the feature.
It makes the unit tests more intrusive and flaky.


This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 23, 2019

/retest

@numerology
Copy link

/lgtm

@Ark-kun Ark-kun force-pushed the SDK---Compiler---Deprecated-dsl-compile---package branch from 833b286 to aa7c1d9 Compare August 27, 2019 21:21
@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 27, 2019

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 28, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 28, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 94b11de into kubeflow:master Aug 28, 2019
ajchili pushed a commit to ajchili/pipelines that referenced this pull request Aug 28, 2019
* SDK - Compiler - Deprecated dsl-compile --package

* Switched to the Deprecated library
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Kim Caffeinism <make.dirty.code@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants