Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chor(test) : Fix kfp-sdk-test for different python versions #11559

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

chahatsagarmain
Copy link
Contributor

Description of your changes:
Resolve #11558

Checklist:

Copy link

Hi @chahatsagarmain. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chahatsagarmain
Copy link
Contributor Author

@hbelmiro can you run the test once ?

@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

@chahatsagarmain
Copy link
Contributor Author

@hbelmiro still working on this , I was running tests on my fork .

@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Jan 28, 2025
@chahatsagarmain chahatsagarmain marked this pull request as ready for review January 28, 2025 21:21
@google-oss-prow google-oss-prow bot requested a review from DharmitD January 28, 2025 21:21
@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc @HumairAK

@google-oss-prow google-oss-prow bot removed the lgtm label Feb 7, 2025
@chahatsagarmain
Copy link
Contributor Author

Used some logging to investigate why the test was failing specifically for python 3.13 . The found variable was not being set specifically for python 3.13 . Simplifying the logic to iterate over the method description fixes the issue here .

@chahatsagarmain chahatsagarmain force-pushed the sdk-test branch 2 times, most recently from f47b160 to 805cc39 Compare February 9, 2025 17:04
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 10, 2025
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
@HumairAK
Copy link
Collaborator

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 926aec5 into kubeflow:master Feb 10, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(<test>): kfp-sdk-tests has an error in the python version variable
4 participants