Skip to content

Commit

Permalink
test
Browse files Browse the repository at this point in the history
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>

eol

Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>

fix

Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>

fix test

Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>

fix test

Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>

fix test

Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>

allow class docstring

Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>

test

Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>

eol

Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
  • Loading branch information
chahatsagarmain committed Feb 9, 2025
1 parent 88a0e3d commit f47b160
Showing 1 changed file with 16 additions and 24 deletions.
40 changes: 16 additions & 24 deletions sdk/python/kfp/cli/utils/parsing.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,7 @@ def get_param_descr(fn: Callable, param_name: str) -> str:
Returns:
str: The description of the parameter.
"""
if not isinstance(fn, type) and not callable(fn):
docstring = fn.__class__.__doc__
else:
docstring = fn.__doc__
docstring = fn.__doc__

if docstring is None:
raise ValueError(
Expand All @@ -46,24 +43,19 @@ def get_param_descr(fn: Callable, param_name: str) -> str:
raise ValueError(f'No Args section found in docstring of {fn}')

lines = lines[i + 1:]
# More lenient regex pattern
first_line_args_regex = rf'^\s*{param_name}\s*(?:\([^)]*\))?\s*:\s*'
first_already_found = False
return_lines = []
for line in lines:
if not first_already_found and re.match(first_line_args_regex,
line.lstrip()):
new_line = re.sub(first_line_args_regex, '', line.strip())
return_lines.append(new_line)
first_already_found = True
first_indentation_level = len(line) - len(line.lstrip())
continue

if first_already_found:
indentation_level = len(line) - len(line.lstrip())
if indentation_level <= first_indentation_level:
return ' '.join(return_lines)
else:
return_lines.append(line.strip())
first_line_args_regex = rf'^{param_name}( \(.*\))?: '
for i, line in enumerate(lines):
stripped = line.lstrip()
match = re.match(first_line_args_regex, stripped)
if match:
description = [re.sub(first_line_args_regex, '', stripped)]
# Collect any additional lines that are more indented
current_indent = len(line) - len(stripped)
for next_line in lines[i + 1:]:
next_indent = len(next_line) - len(next_line.lstrip())
if next_indent <= current_indent:
break
description.append(next_line.strip())
return ' '.join(description)
raise ValueError(
f'Could not find parameter {param_name} in docstring of {fn}')
f'Could not find parameter {param_name} in docstring of {fn}')

0 comments on commit f47b160

Please sign in to comment.