Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow code, test image code and code being tested can still desync. #198

Closed
Ark-kun opened this issue Nov 10, 2018 · 2 comments
Closed

Prow code, test image code and code being tested can still desync. #198

Ark-kun opened this issue Nov 10, 2018 · 2 comments
Assignees

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 10, 2018

When Prow runs tests it clones the repo and merges the PR branch into master at time T0. This includes test/presubmit_tests.sh and test/*.yaml

When build-image builds test images, it clones the repo and merges the PR branch into master at time ~T1 separately for each image. This includes test/*/run_test.sh and the whole frontend test suite

When a test runs, it clones the repo and merges the PR branch into master at time ~T2 separately for each test.

This was the issue that most likely caused #196

That issue got fixed when I explicitly re-run build-image step for all problematic PRs.

I do not fully understand how the unit test image has caused problem, since it should only contain the run_test.sh script and couple of Go packages.

@IronPan
Copy link
Member

IronPan commented Nov 11, 2018

Please see comment in #196 for more details.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 20, 2019

Fixed in #315

@Ark-kun Ark-kun closed this as completed Mar 20, 2019
@Ark-kun Ark-kun self-assigned this Mar 20, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
* name is used in the XMl file containing the test results. If name
  isn't set the XML file won't be created correctly and therefore
  not surfaced in gubernator correctly; see kubeflow/kubeflow#1426

* Related to kubeflow/kubeflow#1426
m-rafeeq referenced this issue in m-rafeeq/data-science-pipelines Jan 21, 2025
…ct-manager-reqs

fix(backend): Update Artifact Manager Dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants