Skip to content

Commit

Permalink
Require name to be set for TestSuite. (kubeflow#198)
Browse files Browse the repository at this point in the history
* name is used in the XMl file containing the test results. If name
  isn't set the XML file won't be created correctly and therefore
  not surfaced in gubernator correctly; see kubeflow/kubeflow#1426

* Related to kubeflow/kubeflow#1426
  • Loading branch information
jlewi authored and k8s-ci-robot committed Aug 30, 2018
1 parent d5a7ffd commit 82b5d78
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions py/kubeflow/testing/test_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ class TestSuite(junit_xml.TestSuite):
"""A suite of test cases."""

def __init__(self, name, test_dir, artifacts_dir, logs_dir, **kwargs):
if not name:
raise ValueError("name must be set.")
self.test_dir = test_dir
self.artifacts_dir = artifacts_dir
self.logs_dir = logs_dir
Expand Down

0 comments on commit 82b5d78

Please sign in to comment.