Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add support for Vega/Vega Lite visualizations #1924

Closed
ajchili opened this issue Aug 22, 2019 · 5 comments
Closed

[FR] Add support for Vega/Vega Lite visualizations #1924

ajchili opened this issue Aug 22, 2019 · 5 comments
Assignees
Labels
kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.

Comments

@ajchili
Copy link
Member

ajchili commented Aug 22, 2019

Vega and Vega Lite are visualizations built with JSON to specify the appearance and interactive behavior of a visualization. This is similar to #1472 but rather than being Python based, it is based in Javascript and is built with support for Protovis and D3.js. Introducing Vega or Vega Lite as a visualization tool (as recommended by @eterna2) would vastly improve the extensible of the visualizations offered within Kubeflow Pipelines. To help guide this FR, I plan on writing a doc for implementing Vega/Vega Lite within Kubeflow Pipelines given the current visualization solution that is being implemented.

@ajchili
Copy link
Member Author

ajchili commented Aug 22, 2019

/assign @ajchili

@eterna2
Copy link
Contributor

eterna2 commented Jan 10, 2020

Hi any updates on this? If not, I don't mind contributing as vega is one of my fav viz lib?

@ajchili
Copy link
Member Author

ajchili commented Jan 13, 2020

Hey @eterna2, I unfortunately did not make any progress for this FR. If possible, I would recommend writing up a design doc and have it be reviewed by the Pipelines team. This will ensure that the desired feature aligns with the goals of Pipelines and prevents work from being duplicated or scraped. Please let me know how I can help!

@stale
Copy link

stale bot commented Jun 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 24, 2020
@stale
Copy link

stale bot commented Jul 2, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Jul 2, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
…w#1926)

* added built-in cluster servingruntime for existing framework

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* replace placeholders in runtime container

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* convert isvc old schema to new schema

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* added triton as supported framework for backward compatibility

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* assigning predictor spec issue fix

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* incorporated review comments on serving runtimes

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* predictor model name issue fix

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* update image tag and protocol version

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* isvc update issue fix

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* fix e2e test failure issues

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* - remove gpu clusterservingruntimes
 - update image tag if gpu enabled or runtime version provided
 - update mlserver, tensorflow image versions

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* added ut for new utils funcs

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* updated model supported versions

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* Fix protocol version

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.
Projects
None yet
Development

No branches or pull requests

3 participants