-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable flexible and custom visualizations for artifacts produced by Kubeflow Pipelines #1472
Comments
/assign @ajchili |
@neuromage: GitHub didn't allow me to assign the following users: ajchili. Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
You are talking about custom visualization, does this mean the TFX components already have support for the basic visualization options of kubeflow? For now I would we happy to have e.g. tables of the input data or a tensorboard of the training. This should only require writing that data to the metric file for Kubeflow. I am happy to assist on this but don’t want to reinvent the wheel. So if any works has already been done this, maybe we can align first. |
Created local demonstration of kubeflow#1472 using a new viewer component.
Created local demonstration of kubeflow#1472 using a new viewer component.
Created local demonstration of kubeflow#1472 using a new viewer component.
Any updates on this? @ajchili does your local demonstrator work? |
@rummens I am still working on a demo for this functionality. Unfortunately, I do not have one working yet, I am hoping to have a working demo by the end of this week. |
No problem and thanks for the update. Which components will your development support? All TFX components or just specific ones, the most interesting ones being transform, Trainer and Model Validation? |
I am starting with TFDV and an ROC curve for the demo. Afterwards, I am hoping to have support for any Python visualization library. |
Sounds awesome, can’t wait to test ;-) Is tensorboard for the Trainer supported yet? KFP already has it integrated, just not sure if the user has to change the trainer component in order to use it? |
@jingzhang36 @rileyjbauer can we enable tensorboard link outside of ui_metadata.json? I'm thinking it would show up when the artifact being passed around is TFX's |
@neuromage Riley shall know best on this, but I feel like we can if we want to enable tb link outside of /mlpipeline-ui-metadata.json. BTW, can we have the uri to logs (contained in ModelExportPath) copied to our /mlpipeline-ui-metadata.json....... |
@rummens I have a basic e2e demo running within my cluster. It is not user-friendly at the moment and requires that you edit the ml-pipeline and ml-pipeline-ui deployment and create a new service and deployment. If you would like to test it early here are the steps to get started. If you run into any issues with these steps please let me know!
Again, it is not in a finished state and should be used with that understanding. |
Thanks very much for the update, I am trying to find some time to test it. So far I can report that the images build fine, that all I could get done so far. Sorry for delay but I promise to try it out soon. |
@rummens there is no rush! Thanks for taking the time to go through this and test it out. As an FYI, I have added basic support for TFDV visualizaitons. You will need to be at commit 808afa451362363041fac652093cabed08262040. Once this is done, follow these steps to view the visualization. As a side note, there is an unresolved issue with timeouts which may cause the TFDV visualization to fail, if it happens please try to rerun the visualization. Steps:
|
A follow up to the comment above. It appears that the usage of ambassador could be leading to unexpected timeout when making API requests from the frontend. One method to circumvent this issue is to follow these steps in order to setup a new cluster with a lightweight version of pipelines. |
Are you running against 0.5 or 0.6 because in 0.6 the ambassador seems to be replaced by istio? |
@rummens previously I was running 0.5 but I recently switched to 0.6 due to the switch away from ambassador. I can also confirm that switching to 0.6 resolved the timeout issue. Upgrading to 0.6 is not required but it removed the timeout limitation. |
/close |
@ajchili: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Swap boto3 in for minio in storage initializer * This commit includes the following changes: - Refactored tests to mock boto3 while keeping same behaviour - Skip directory object itself (any object with a trailing '/') when filtering/listing bucket objects - Keep full path when downloading single object - Added some comments to _download_s3 method - Use latest boto3/botocore versions * Linting fixes Co-authored-by: Matthew Conniff <mvconniff@gmail.com>
We'd like to enable users to easily add visualizations of artifacts in the UI. Today, the KFP UI only supports a few basic visualizations, and custom visualizations (such as those produced by TFMA/TFDV libraries) need a lot of custom work by the user to produce a HTML file that can be displayed in the KFP UI. This issue is meant to track work for greatly simplifying the work needed by the user to achieve the same effect.
The text was updated successfully, but these errors were encountered: