-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX katib-db-manager secrets and service to connect to mysql #2981
Conversation
3c5b299
to
23d15cf
Compare
@pedrovgp you need to fix it here https://github.com/kubeflow/katib/tree/master/manifests/v1beta1/installs/katib-with-kubeflow and then synchronize with https://github.com/kubeflow/manifests/blob/master/hack/synchronize-katib-manifests.sh. But i am wondering because our cicd works well https://github.com/kubeflow/manifests/blob/master/.github/workflows/katib_test.yaml as you can see here https://github.com/kubeflow/manifests/actions/runs/13119220501/job/36600993054 |
But lets keep this PR open for our integration tests |
Indeed, that's weird. You mentioned it is the same as in Kubeflow 1.9. Katib in 1.9 was also not working for us. I don't think it is anything EKS related because the secrets and app mappings were wrong within the cluster, it had nothing to do with any external AWS resources. |
@kubeflow/release-team definitely something we need to consider for Kubeflow 1.10 |
also
needs to be fixed in the upstream manifests |
and the tests must be fixed to fail on such problems. Maybe wee need to extend https://github.com/kubeflow/manifests/blob/588e49e267f070578ad0e7a717d9ba79d652371d/.github/workflows/katib_test.yaml to also check whether stuff is persisted to the database. |
Hi @juliusvonkohout , I made the PR in the Katib repo. Should I now wait for it to merge to master and after that run https://github.com/kubeflow/manifests/blob/master/hack/synchronize-katib-manifests.sh. and make the PR here? |
Well as a first step you should extend the tests mentioned above to fail with the current setup, see #2981 (comment). Such problems must be caught in our CI/CD. But otherwise yes, you can work in parallel on both repositories and i can do the synchronization later on. |
8ea8b03
to
da72660
Compare
/ok-to-test @pedrovgp please make sure to also have the changes int the upstream katib master branch. In the best case we keep them in synchronization for now. |
da72660
to
0f41b35
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pedrovgp why did you close the PR ? We need it to run the integration tests here as well. |
ah ok, continued in #2983 |
This PR was originated by issue 2980
Investigating the issue, we discovered two problems:
This PR fixes both issues by adding patches to the "katib-with-kubeflow" install mode.