FIX secrets and mysql app selector for kubeflow install #2510
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Pedro Viana <pedro.viana@nubank.com.br>
0d2d278 to
36e18c7
Compare
b496f43 to
7c9a3c7
Compare
Signed-off-by: Pedro Viana <pedro.viana@nubank.com.br>
7c9a3c7 to
8cc3427
Compare
| @@ -11,18 +11,16 @@ resources: | |||
| images: | |||
| - name: docker.io/kubeflowkatib/katib-controller | |||
| newName: docker.io/kubeflowkatib/katib-controller | |||
| newTag: latest | |||
| newTag: v0.17.0 | |||
There was a problem hiding this comment.
Is latest not the correct tag on the master branch?
There was a problem hiding this comment.
As I checked your commit in my local, this seems not to be available:
Error from server (InternalError): error when creating "examples/v1beta1/hp-tuning/grid.yaml": Internal error occurred: failed calling webhook "defaulter.experiment.katib.kubeflow.org": failed to call webhook: Post "https://katib-controller.kubeflow.svc:443/mutate-experiment?timeout=10s": tls: failed to verify certificate: x509: certificate signed by unknown authority{"level":"info","ts":"2025-02-08T15:12:33Z","msg":"Starting workers","controller":"suggestion-controller","worker count":1}
{"level":"info","ts":"2025-02-08T15:12:33Z","msg":"Starting workers","controller":"experiment-controller","worker count":1}
2025/02/08 15:14:41 http: TLS handshake error from 10.244.0.1:63983: remote error: tls: bad certificate
2025/02/08 15:14:44 http: TLS handshake error from 10.244.0.1:63924: remote error: tls: bad certificate
2025/02/08 15:15:28 http: TLS handshake error from 10.244.0.1:56985: remote error: tls: bad certificate
2025/02/08 15:17:44 http: TLS handshake error from 10.244.0.1:14775: remote error: tls: bad certificateCould you focus only on 36e18c7 in this PR due to release cycle?
As separately, we can open dedicated PR only for 8cc3427.
| @@ -11,18 +11,16 @@ resources: | |||
| images: | |||
| - name: docker.io/kubeflowkatib/katib-controller | |||
| newName: docker.io/kubeflowkatib/katib-controller | |||
| newTag: latest | |||
| newTag: v0.17.0 | |||
There was a problem hiding this comment.
| newTag: v0.17.0 | |
| newTag: latest |
The head branch should use the latest image.
| - name: docker.io/kubeflowkatib/katib-db-manager | ||
| newName: docker.io/kubeflowkatib/katib-db-manager | ||
| newTag: latest | ||
| newTag: v0.17.0 |
There was a problem hiding this comment.
| newTag: v0.17.0 | |
| newTag: latest |
|
|
||
| patchesStrategicMerge: | ||
| - patches/remove-namespace.yaml | ||
| newTag: v0.17.0 |
There was a problem hiding this comment.
| newTag: v0.17.0 | |
| newTag: latest |
Maybe you are missing cert-manager from kubeflow/manifests https://github.com/kubeflow/manifests/blob/59d1312e3f0b818607ff1f83da0574a9f6a75569/example/kustomization.yaml#L73 . This is for the Multi-User "kubeflow" installation of katib https://github.com/kubeflow/manifests/blob/59d1312e3f0b818607ff1f83da0574a9f6a75569/example/kustomization.yaml#L69 |
|
@pedrovgp the test in /katib and /manifests are different. Please keep the same changes (PR) against kubeflow/manifest open to get feedback from our tests in kubeflow/manifests. We need to have the tests from both repositories. |
This is the original PR (with linked issue) that originated these changes.
FOR REVIEWERS: the first commit is the relevant one, the second is fixing deprecation warnings from patcheStrategicMerge and vars.