Automated cherry pick of #1376: Add knative and kfserving to GCP stack #1381: knative shouldn't be part of GCP stack kustomization Cherry pick of #1376 #1381 on v1.1-branch. #1376: Add knative and kfserving to GCP stack #1381: knative shouldn't be part of GCP stack kustomization #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 14, 2020 11:13
* Related to: GoogleCloudPlatform/kubeflow-distribution#74 Fix common labels for knative and kfserving. * There were typos and they were including labels that by convention we currently don't want in common labels.
* related to GoogleCloudPlatform/kubeflow-distribution#74 * knative needs to be installed in its own namespace so we don't want to make it part of the kubeflow namespace kustomization package * We will have to install it separately in the blueprint.
|
This change is |
|
/assign @Bobgy /hold I'm preparing this PR and would appreciate an LGTM so its ready to go once the following occurs
|
|
/lgtm |
|
This appears to be working on master although the test is still failing. So I'm approving it to unblock the next minor release. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to GoogleCloudPlatform/kubeflow-distribution#74