Manifests release 1.1

[krishnadurai]

Opening this issue to track releasing manifests as part of 1.1.

• Ref: Release KF 1.1 kubeflow#5022
• We will need to
  • Cut a release branch
  • Generate Manifests for each kfdef

/assign @krishnadurai

[issue-label-bot]

Issue-Label Bot is automatically applying the labels:

Label	Probability
kind/feature	0.78
area/kfctl	0.73

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

[issue-label-bot]

Issue-Label Bot is automatically applying the labels:

Label	Probability
area/kfctl	0.73
kind/feature	0.78

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

[issue-label-bot]

Issue-Label Bot is automatically applying the labels:

Label	Probability
area/engprod	0.74

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

[jlewi]

Looks like the postsubmit tests are failing. Looks like the TFJob operator tests are out of sync.

kubeflow-manifests-postsubmit-unit-d6a25c6-5684-13a5-1216454708.log.txt

[jlewi]

@krishnadurai Can you fix the tests and then once the tests are fixed cut the branch?

[jlewi]

@krishnadurai looks like the tests are still failing

===== ACTUAL END ==========================================
  EXPECTED                                                                ACTUAL
  --------                                                                ------
  apiVersion: admissionregistration.k8s.io/v1beta1                        apiVersion: admissionregistration.k8s.io/v1beta1
  kind: MutatingWebhookConfiguration                                      kind: MutatingWebhookConfiguration
  metadata:                                                               metadata:
    annotations:                                                            annotations:
      cert-manager.io/inject-ca-from: kubeflow/admission-webhook-cert         cert-manager.io/inject-ca-from: kubeflow/admission-webhook-cert
    labels:                                                                 labels:
      app: admission-webhook                                                  app: admission-webhook
      app.kubernetes.io/component: poddefaults                                app.kubernetes.io/component: poddefaults
      app.kubernetes.io/name: poddefaults                                     app.kubernetes.io/name: poddefaults
      kustomize.component: admission-webhook                                  kustomize.component: admission-webhook
    name: admission-webhook-mutating-webhook-configuration                  name: admission-webhook-mutating-webhook-configuration
  webhooks:                                                               webhooks:
  - clientConfig:                                                         - clientConfig:
      caBundle: ""                                                            caBundle: ""
      service:                                                                service:
        name: admission-webhook-service                                         name: admission-webhook-service
        namespace: kubeflow                                                     namespace: kubeflow
        path: /apply-poddefault                                                 path: /apply-poddefault
    name: admission-webhook-deployment.kubeflow.org                         name: admission-webhook-deployment.kubeflow.org
X    rules:                                                                  namespaceSelector:
X    - apiGroups:                                                              matchLabels:
X      - ""                                                                      app.kubernetes.io/part-of: kubeflow-profile
X      apiVersions:                                                          rules:
X      - v1                                                                  - apiGroups:
X      operations:                                                             - ""
X      - CREATE                                                                apiVersions:
X      resources:                                                              - v1
X      - pods                                                                  operations:
X                                                                              - CREATE
X                                                                              resources:
X                                                                              - pods
   TestKustomize: test_util.go:176: Expected not equal to actual
--- FAIL: TestKustomize (5.45s)

Even after #1297; My conjecture is that when you generated the tests you weren't based off of the latest master and as a result you are missing #1284

[jlewi]

Tests are passing on
d771072

We should cut the 1.1 branch on that commit.

[jlewi]

Branch 1.1. has been cut.

[jlewi]

@krishnadurai Is there any more work here? Are we just waiting to tag a particular commit as 1.1.0?

[krishnadurai]

@Jeffwan had mentioned that he wants to patch in a few changes. Otherwise we look good to go for 1.1.0.

[jlewi]

Created a Tag from the latest commit
https://github.com/kubeflow/manifests/releases/tag/v1.1-rc.0

[jlewi]

@Bobgy What cherry-picks do we want to get onto the 1.1 branch for the next GCP rc?

• We need Automated cherry pick of #1376: Add knative and kfserving to GCP stack #1381: knative shouldn't be part of GCP stack kustomization Cherry pick of #1376 #1381 on v1.1-branch. #1376: Add knative and kfserving to GCP stack #1381: knative shouldn't be part of GCP stack kustomization #1385 for knative
• What PRs do we need for multi-user pipelines
  I assume we need Cherry pick KFP multi user changes to 1.1 branch #1383 any other changes?
• Remove katib-metricscollector-injection label from Kubeflow namespace #1387 to scope katib collector

[Bobgy]

@jlewi all required cherry picks for multi-user pipelines are already in. Just double checking we are not publishing the public release right now? I found some issues in kubeflow/pipelines#3241 (comment), and need some time to investigate.

[jlewi]

@Bobgy We need to get the fixes for the KptFiles in GoogleCloudPlatform/kubeflow-distribution#89

[jlewi]

On GCP side we got broken by changes in kpt (GoogleCloudPlatform/kubeflow-distribution#89). This is now fixed on master.
Master is now green except for 2 tests which appear to be failing due to problems in the tests
https://k8s-testgrid.appspot.com/sig-big-data#kubeflow-gcp-blueprints-periodic-master

Plan is to get the fixes for GoogleCloudPlatform/kubeflow-distribution#89 cherry-picked into the 1.1 branch and then cut an RC.

[jlewi]

New RC is cut:
https://github.com/kubeflow/manifests/tree/v1.1-rc.1

[jlewi]

New RC
https://github.com/kubeflow/manifests/releases/tag/v1.1-rc.2

This one is an actual release (tag) and not a branch. This is what we want

[jlewi]

v1.1.0 has been finalized.
https://github.com/kubeflow/manifests/releases/tag/v1.1.0

Note I had to create a tag and not a release because subsequent changes had been cherry-picked onto the branch and GitHub only allows creating a release from the of a branch.