Skip to content
This repository was archived by the owner on Aug 17, 2023. It is now read-only.

Make KFCTL E2E tests self contained in repo #90

Merged
merged 37 commits into from
Nov 11, 2019

Conversation

gabrielwen
Copy link
Contributor

@gabrielwen gabrielwen commented Nov 8, 2019

Related to #91
Related to #7

  • Make KFCTL E2E tests self-contained within repo.
  • Reorder python testing codes to be within package path: kubeflow/kfctl/...

This change is Reviewable

@gabrielwen
Copy link
Contributor Author

/retest

1 similar comment
@gabrielwen
Copy link
Contributor Author

/retest

@jlewi
Copy link
Contributor

jlewi commented Nov 8, 2019

@gabrielwen Do you need to

  • Add the new flag to conftest?
  • Modify the workflow?

@jlewi
Copy link
Contributor

jlewi commented Nov 9, 2019

Rename 'py/kfctl to py/kubeflow/kfct' So that all imports are import kubeflow.kfctl

@gabrielwen
Copy link
Contributor Author

/retest

@gabrielwen
Copy link
Contributor Author

/retest

@gabrielwen gabrielwen changed the title Kfctl e2e build path Make KFCTL E2E tests self contained in repo Nov 11, 2019
@gabrielwen
Copy link
Contributor Author

/retest

@gabrielwen
Copy link
Contributor Author

/retest

manually cleaned up quotas.

@gabrielwen
Copy link
Contributor Author

@jlewi this PR is ready.

@kunmingg
Copy link
Contributor

/lgtm

@jlewi
Copy link
Contributor

jlewi commented Nov 11, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4f13e52 into kubeflow:master Nov 11, 2019
@gabrielwen gabrielwen deleted the kfctl-e2e branch November 11, 2019 21:33
k8s-ci-robot pushed a commit that referenced this pull request Dec 18, 2019
…repo (#150)

* add kfctl repo path info

* use kfctl_repo_path

* pytest init

* cp

* update

* pkg

* rename

* cp test_deploy.py

* mv vm_util

* update prow

* update import path

* update

* update

* add fixture

* fix

* fix

* add missing dep

* fix

* cp run_with_retry

* update test-dir-delete

* cp kfctl_second_apply.py

* create folder

* copy pytests

* cp ci

* mv -i

* cp testing

* mv util/

* pkg

* pkg

* pkg

* update description

* pkg

* update prow

* rm

* test hacking

* doc

* reorder pythonpath

* fix test

* disable notebook-test

* replace invalid char in job name
crobby pushed a commit to crobby/kfctl that referenced this pull request Feb 19, 2021
* Release of version 1.0.0

* Update CHANGELOG.md

Co-authored-by: Kebechet <noreply+kebechet@redhat.com>
Co-authored-by: Landon LaSmith <2432396+LaVLaS@users.noreply.github.com>
crobby pushed a commit to crobby/kfctl that referenced this pull request Feb 25, 2021
* Release of version 1.0.0

* Update CHANGELOG.md

Co-authored-by: Kebechet <noreply+kebechet@redhat.com>
Co-authored-by: Landon LaSmith <2432396+LaVLaS@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants