Skip to content

Commit

Permalink
Cleanup OWNERS (#89)
Browse files Browse the repository at this point in the history
#### Motivation

Currently, pull requests get auto-assigned `reviewers` (and `approvers`) by the @kserve-oss-bot
However, many of the reviewers and approvers are no longer active. When inactive reviewers are auto-assigned, then active contributors who could actually help with reviews are not notified about new PRs.

Similarly, the @kserve-oss-bot adds a message to PRs about who is allowed to approve PRs, which often points to inactive contributors.

#### Modifications

- Following [Kubernetes guidance](https://www.kubernetes.dev/docs/guide/owners/#cleanup), moving inactive `approvers` under `emeritus_approvers`, removing inactive contributors from list of `reviewers`
- Adding currently active contributors to the list of `reviewers`
- Removing `reviewers` who are no longer working on the project

#### Result

An updated OWNERS file. Auto-assigned reviewers are currently active.

#### Related PRs

- [ ] #89
- [ ] kserve/modelmesh-runtime-adapter#44
- [ ] kserve/modelmesh-serving#354


Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
  • Loading branch information
ckadner authored Apr 13, 2023
1 parent d1d0156 commit 9cc40e3
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions OWNERS
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
approvers:
- animeshsingh
- njhill
- pvaneck
- tjohnson31415
reviewers:
- animeshsingh
- njhill
- pvaneck
- tedhtchang
- Tomcli
- chinhuang007
- tjohnson31415
- ckadner
- rafvasq
emeritus_approvers:
- animeshsingh # 2023-04-12
- pvaneck # 2023-04-12

0 comments on commit 9cc40e3

Please sign in to comment.