Cleanup OWNERS #354
Merged
Cleanup OWNERS #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add currently active contributors to the list of reviewers - Remove reviewers who are no longer working on the project - Move inactive approvers under emeritus_approvers https://www.kubernetes.dev/docs/guide/owners/#cleanup Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
This was referenced Apr 12, 2023
njhill
approved these changes
Apr 13, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
kserve-oss-bot
pushed a commit
to kserve/modelmesh-runtime-adapter
that referenced
this pull request
Apr 13, 2023
#### Motivation Currently, pull requests get auto-assigned `reviewers` (and `approvers`) by the @kserve-oss-bot However, many of the reviewers and approvers are no longer active. When inactive reviewers are auto-assigned, then active contributors who could actually help with reviews are not notified about new PRs. Similarly, the @kserve-oss-bot adds a message to PRs about who is allowed to approve PRs, which often points to inactive contributors. #### Modifications - Following [Kubernetes guidance](https://www.kubernetes.dev/docs/guide/owners/#cleanup), moving inactive `approvers` under `emeritus_approvers`, removing inactive contributors from list of `reviewers` - Adding currently active contributors to the list of `reviewers` - Removing `reviewers` who are no longer working on the project #### Result An updated OWNERS file. Auto-assigned reviewers are currently active. #### Related PRs - [ ] kserve/modelmesh#89 - [ ] #44 - [ ] kserve/modelmesh-serving#354 Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
kserve-oss-bot
pushed a commit
to kserve/modelmesh
that referenced
this pull request
Apr 13, 2023
#### Motivation Currently, pull requests get auto-assigned `reviewers` (and `approvers`) by the @kserve-oss-bot However, many of the reviewers and approvers are no longer active. When inactive reviewers are auto-assigned, then active contributors who could actually help with reviews are not notified about new PRs. Similarly, the @kserve-oss-bot adds a message to PRs about who is allowed to approve PRs, which often points to inactive contributors. #### Modifications - Following [Kubernetes guidance](https://www.kubernetes.dev/docs/guide/owners/#cleanup), moving inactive `approvers` under `emeritus_approvers`, removing inactive contributors from list of `reviewers` - Adding currently active contributors to the list of `reviewers` - Removing `reviewers` who are no longer working on the project #### Result An updated OWNERS file. Auto-assigned reviewers are currently active. #### Related PRs - [ ] #89 - [ ] kserve/modelmesh-runtime-adapter#44 - [ ] kserve/modelmesh-serving#354 Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Jooho
added a commit
to Jooho/modelmesh-serving
that referenced
this pull request
May 5, 2023
Signed-off-by: jooho <jlee@redhat.com>
1 task
Jooho
pushed a commit
to red-hat-data-services/modelmesh-runtime-adapter
that referenced
this pull request
May 16, 2023
Currently, pull requests get auto-assigned `reviewers` (and `approvers`) by the @kserve-oss-bot However, many of the reviewers and approvers are no longer active. When inactive reviewers are auto-assigned, then active contributors who could actually help with reviews are not notified about new PRs. Similarly, the @kserve-oss-bot adds a message to PRs about who is allowed to approve PRs, which often points to inactive contributors. - Following [Kubernetes guidance](https://www.kubernetes.dev/docs/guide/owners/#cleanup), moving inactive `approvers` under `emeritus_approvers`, removing inactive contributors from list of `reviewers` - Adding currently active contributors to the list of `reviewers` - Removing `reviewers` who are no longer working on the project An updated OWNERS file. Auto-assigned reviewers are currently active. - [ ] kserve/modelmesh#89 - [ ] kserve#44 - [ ] kserve/modelmesh-serving#354 Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, pull requests get auto-assigned
reviewers(andapprovers) by the @kserve-oss-botHowever, many of the reviewers and approvers are no longer active. When inactive reviewers are auto-assigned, then active contributors who could actually help with reviews are not notified about new PRs.
Similarly, the @kserve-oss-bot adds a message to PRs about who is allowed to approve PRs, which often points to inactive contributors.
Modifications
approversunderemeritus_approvers, removing inactive contributors from list ofreviewersreviewersreviewerswho are no longer working on the projectResult
An updated OWNERS file. Auto-assigned reviewers are currently active.
Related PRs