test: Run GitHub actions on release-* branches
#299
Conversation
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
|
Oh, interesting. Seems like the FVT got triggered even though there are no functional changes that should warrant that. Maybe we need to update the path-ignore expressions 🤔 |
Ah, nevermind. The FVTs want to be run when the FVT workflow file gets changed :-) |
release-* branchesrelease-* branches
#### Motivation Fix vulnerabilities in the ModelMesh Controller image. #### Modifications 1. Remove dependencies to any packages in the runtime. 2. Updated Go version to the latest version. #### Result The feature is functionally working, I have tested it on my own cluster. Signed-off-by: JasmondL <Jasmond.Ming.Quan.Loh@sap.com> Co-authored-by: JasmondL <Jasmond.Ming.Quan.Loh@sap.com> Co-authored-by: Jasmond L <120363110+JasmondL@users.noreply.github.com>
* release: Update image tags for v0.10.0-rc0 Also update KServe go dependency to v0.10.0-rc1 * Update release process doc * Update links in release process doc * Restore RELEASE_PROCESS.md Will update it in main after this release is done * Update go.sum Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
#### Motivation Missed to update on doc in previous round. #### Modifications Edit the `docs/quickstart.md` file, updating the `RELEASE` variable in the "Get the latest release" section to the new release branch name. #### Result Correct version of release branch in Quickstart guide /cc @njhill /assign @njhill Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ckadner, rafvasq The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#### Motivation Quickstart should use namespace scope mode for simplicity. In current version there is an inconsistency wrt `ServingRuntimes` vs `ClusterServingRuntimes`. #### Modifications - `docs/install/install-script.md` (correct a typo) - `docs/quickstart.md` (change install command for ns scope mode and add missing `torchserv` serving runtime) - `scripts/install.sh` (fix `sed -i` commands) #### Result Quickstart install steps work like a charm again :-) #### TODOs Once merged into `main`, we will need to update the `release-0.10` branch as well --- /cc @njhill /assign @njhill Signed-off-by: Christian Kadner <ckadner@us.ibm.com> (cherry picked from commit fbd8c62)
|
I will open a new PR with just the workflow file changes. The unrelated merge commits should not be in here and might overwrite changes that were done after this PR was created. |
|
New (and improved) PR: #310 |
#### Motivation When we create a new release we need the GitHub actions to run for - Lint - Unit test - FVT - Image build and push #### Modifications Update the Github workflow definitions to include any `release-..` branches. #### Result The GitHub action run on PR and pushed to the release branch. As can be seen in this PR targeting the `release-0.10` branch: #298 --- **Note**: same (intended) changes as in PR #299 -- but without the merge commits /cc @njhill @rafvasq /assign @njhill Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Motivation
When we create a new release we need the GitHub actions to run for
Modifications
Update the Github workflow definitions to include any
release-..branches.Result
The GitHub action run on PR and pushed to the release branch.
As can be seen in this PR targeting the
release-0.10branch:#298
/cc @njhill @rafvasq