Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Update image tags for v0.10.0-rc0 #296

Merged
merged 5 commits into from
Jan 9, 2023

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Jan 6, 2023

Motivation

Prepare for v0.10.0 release

Modifications

  • Update image tags for v0.10.0-rc0 for modelmesh, modelmesh-runtime-adapter, modelmesh-controller, and rest-proxy container images:
    • Edit newTag in config/manager/kustomization.yaml.
    • Edit the modelmesh, modelmesh-runtime-adapter, and rest-proxy image tags in config/default/config-defaults.yaml.
    • Edit the config/dependencies/quickstart.yaml file, changing the kserve/modelmesh-minio-examples image tag to use the pinned version.
    • Edit the docs/component-versions.md file with the version and component versions.
    • Edit the docs/install/install-script.md file, updating the RELEASE variable in the Installation section to the new release branch name.
    • Edit the docs/quickstart.md file, updating the RELEASE variable in the Get the latest release section to the new release branch name.
    • Edit the scripts/setup_user_namespaces.sh file, changing the modelmesh_release version.
  • Update KServe go dependency to v0.10.0-rc1

Note: the corresponding container images for modelmesh, modelmesh-runtime-adapter have been created prior to this PR by creating a pre-release on the respective GitHub repositories.

FYI: Compare the changes in this PR to the once from the v0.9.0-rc0 pre-release:
https://github.com/kserve/modelmesh-serving/pull/179/files

@ckadner ckadner requested review from rafvasq and njhill January 6, 2023 20:53
@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ckadner
To complete the pull request process, please assign animeshsingh after the PR has been reviewed.
You can assign the PR to them by writing /assign @animeshsingh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner
Copy link
Member Author

ckadner commented Jan 6, 2023

@njhill -- please hold off on this until I updated the GitHub actions

@ckadner ckadner marked this pull request as ready for review January 7, 2023 01:11
@ckadner
Copy link
Member Author

ckadner commented Jan 7, 2023

Alright @njhill -- all preconditions should be met for this PR to merge now:

  • build + pushed all required -rc0 container images:
    • kserve/modelmesh:v0.10.0-rc0
    • kserve/modelmesh-runtime-adapter:v0.10.0-rc0
    • kserve/modelmesh-minio-examples:v0.10.0
  • GitHub actions are enabled on release-* branches

Docker pushes might not work however, as I have not updated the Dockerhub credentials

@ckadner
Copy link
Member Author

ckadner commented Jan 7, 2023

/retest

@ckadner ckadner force-pushed the release-0.10.0-rc0 branch 2 times, most recently from 8d10205 to ff381bf Compare January 7, 2023 04:43
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member Author

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @njhill -- looks like there is a merge conflict artifact left here? Did you merge something into my fork?

go.sum Outdated Show resolved Hide resolved
Also update KServe go dependency to v0.10.0-rc1

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Will update it in main after this release is done

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner force-pushed the release-0.10.0-rc0 branch from 5caa619 to 8851cdc Compare January 8, 2023 23:17
@njhill
Copy link
Member

njhill commented Jan 9, 2023

/lgtm

@ckadner ckadner added the lgtm label Jan 9, 2023
@njhill njhill merged commit 414a5a4 into kserve:release-0.10 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants