Add support to download model from Azure file share #1985

laozc · 2022-01-12T01:10:58Z

What this PR does / why we need it:
Add support to download model from Azure file share

Which issue(s) this PR fixes:
Fixes #1967

Release note:

Support download model from Azure file share

aws-kf-ci-bot · 2022-01-12T01:11:11Z

Hi @laozc. Thanks for your PR.

I'm waiting for a kserve member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

yuzisun · 2022-01-23T17:22:36Z

/ok-to-test

yuzisun · 2022-02-04T05:47:02Z

@laozc Thanks for this great contribution! Would you be able to add e2e tests for the Azure storage?

laozc · 2022-02-09T03:25:24Z

@yuzisun I saw the e2e test cluster is set up on EKS.
It would be a bit diffcult to maintain an Azure storage in compliance for this case.

yuzisun · 2022-02-12T14:30:49Z

/cc @maganaluis for review

kserve-oss-bot · 2022-02-12T14:30:51Z

@yuzisun: GitHub didn't allow me to request PR reviews from the following users: review, maganaluis, for.

Note that only kserve members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @maganaluis for review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yuzisun · 2022-02-15T06:21:28Z

@yuzisun I saw the e2e test cluster is set up on EKS. It would be a bit diffcult to maintain an Azure storage in compliance for this case.

We can create a kind cluster to test the Azure storage?

Suresh-Nakkeran · 2022-03-09T15:41:44Z

@laozc I'm receiving credential error.
ValueError("Token credentials not supported by the File service.")
It seems we should use account key to access file share.
Refer: Azure/azure-sdk-for-python#13033 (comment)
cc: @yuzisun

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

kserve-oss-bot · 2022-04-02T08:30:28Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: laozc
To complete the pull request process, please assign animeshsingh after the PR has been reviewed.
You can assign the PR to them by writing /assign @animeshsingh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

laozc · 2022-04-03T07:08:59Z

@Suresh-Nakkeran Storage Account Access Key auth is added in the latest commit.
You may check if you still encounter the same issue.

yuzisun · 2022-04-14T07:38:59Z

@Suresh-Nakkeran Storage Account Access Key auth is added in the latest commit. You may check if you still encounter the same issue.

@Suresh-Nakkeran Can you help verify this?

Suresh-Nakkeran · 2022-04-22T04:51:11Z

@laozc @yuzisun I am receiving below error when I test a model from azure file share. The access key is provided in secret. I also check the changes.

Suresh-Nakkeran · 2022-04-22T05:54:52Z

@laozc is it AZURE_STORAGE_ACCESS_KEY or AZURE_STORAGE_KEY?

laozc · 2022-04-22T05:57:38Z

@laozc is it AZURE_STORAGE_ACCESS_KEY or AZURE_STORAGE_KEY?

AZURE_STORAGE_ACCESS_KEY should be the correct one.

pkg/credentials/azure/azure_secret.go

Suresh-Nakkeran · 2022-05-02T16:12:32Z

pkg/credentials/service_account_credentials.go

@@ -196,6 +197,10 @@ func (c *CredentialBuilder) CreateSecretVolumeAndEnv(namespace string, serviceAc
 			log.Info("Setting secret envs for azure", "AzureSecret", secret.Name)
 			envs := azure.BuildSecretEnvs(secret)
 			container.Env = append(container.Env, envs...)
+		} else if _, ok := secret.Data[azure.AzureStorageAccessKey]; ok {
+			log.Info("Setting secret envs for azure", "AzureSecret", secret.Name)
+			envs := azure.BuildSecretEnvs(secret)


@laozc we should call the new azure.BuildStorageAccessKeySecretEnv function for Storage Access Key.

yuzisun · 2022-05-21T19:26:18Z

@laozc We have merged the PR on top of your commits, thanks for your awesome contributions!

kserve-oss-bot added the do-not-merge/work-in-progress label Jan 12, 2022

kserve-oss-bot requested review from njhill and Tomcli January 12, 2022 01:11

aws-kf-ci-bot added the needs-ok-to-test label Jan 12, 2022

laozc force-pushed the azure-file-share branch from 7b03522 to 7faf390 Compare January 13, 2022 09:34

laozc changed the title ~~[WIP] Add support to download model from Azure file share~~ Add support to download model from Azure file share Jan 13, 2022

kserve-oss-bot removed the do-not-merge/work-in-progress label Jan 13, 2022

laozc force-pushed the azure-file-share branch from 7faf390 to 956333a Compare January 17, 2022 14:46

laozc added 2 commits January 17, 2022 22:51

Add support to Azure file share

932ad4f

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

Add test cases for Azure file share support

459ada9

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

laozc force-pushed the azure-file-share branch from f28d081 to 459ada9 Compare January 17, 2022 14:51

kserve-oss-bot added ok-to-test and removed needs-ok-to-test labels Jan 23, 2022

Merge remote-tracking branch 'origin/master' into azure-file-share

a04e929

laozc added 4 commits April 2, 2022 16:20

Use account access key auth for Azure file storage

500d2fc

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

Merge remote-tracking branch 'origin/master' into azure-file-share

a2485ee

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

Upgrade azure storage file share version

7a503ef

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

Pass Azure access key to storage initializer

d7cec38

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

yuzisun mentioned this pull request May 1, 2022

KServe 0.9 release tracking #2168

Closed

15 tasks

Suresh-Nakkeran reviewed May 4, 2022

View reviewed changes

yuzisun mentioned this pull request May 21, 2022

Storage Initializer Azure Fileshare download tgz RuntimeError ContentType check #1967

Closed

yuzisun closed this May 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to download model from Azure file share #1985

Add support to download model from Azure file share #1985

laozc commented Jan 12, 2022

aws-kf-ci-bot commented Jan 12, 2022

yuzisun commented Jan 23, 2022

yuzisun commented Feb 4, 2022

laozc commented Feb 9, 2022

yuzisun commented Feb 12, 2022

kserve-oss-bot commented Feb 12, 2022

yuzisun commented Feb 15, 2022

Suresh-Nakkeran commented Mar 9, 2022 •

edited

Loading

kserve-oss-bot commented Apr 2, 2022

laozc commented Apr 3, 2022

yuzisun commented Apr 14, 2022

Suresh-Nakkeran commented Apr 22, 2022 •

edited

Loading

Suresh-Nakkeran commented Apr 22, 2022

laozc commented Apr 22, 2022

Suresh-Nakkeran May 2, 2022

yuzisun commented May 21, 2022

Add support to download model from Azure file share #1985

Add support to download model from Azure file share #1985

Conversation

laozc commented Jan 12, 2022

aws-kf-ci-bot commented Jan 12, 2022

yuzisun commented Jan 23, 2022

yuzisun commented Feb 4, 2022

laozc commented Feb 9, 2022

yuzisun commented Feb 12, 2022

kserve-oss-bot commented Feb 12, 2022

yuzisun commented Feb 15, 2022

Suresh-Nakkeran commented Mar 9, 2022 • edited Loading

kserve-oss-bot commented Apr 2, 2022

laozc commented Apr 3, 2022

yuzisun commented Apr 14, 2022

Suresh-Nakkeran commented Apr 22, 2022 • edited Loading

Suresh-Nakkeran commented Apr 22, 2022

laozc commented Apr 22, 2022

Suresh-Nakkeran May 2, 2022

Choose a reason for hiding this comment

yuzisun commented May 21, 2022

Suresh-Nakkeran commented Mar 9, 2022 •

edited

Loading

Suresh-Nakkeran commented Apr 22, 2022 •

edited

Loading