Add test cases for Azure file share support

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

python/kserve/test/test_azure_storage.py

@@ -37,6 +37,33 @@ def create_mock_blob(mock_storage, paths):
     return mock_storage, mock_container
 
 
+def create_mock_dir(name):
+    mock_file = mock.MagicMock()
+    mock_file.name = name
+    mock_file.is_directory = True
+    return mock_file
+
+
+def create_mock_file(name):
+    mock_file = mock.MagicMock()
+    mock_file.name = name
+    mock_file.is_directory = False
+    return mock_file
+
+
+def create_mock_objects_for_file_share(mock_storage, mock_file_items):
+    mock_share = mock.MagicMock()
+    mock_share.list_directories_and_files.side_effect = mock_file_items
+    mock_file = mock.MagicMock()
+    mock_share.get_file_client.return_value = mock_file
+    mock_data = mock.MagicMock()
+    mock_file.download_file.return_value = mock_data
+    mock_svc = mock.MagicMock()
+    mock_svc.get_share_client.return_value = mock_share
+    mock_storage.return_value = mock_svc
+    return mock_storage, mock_share, mock_data
+
+
 def get_call_args(call_args_list):
     arg_list = []
     for call in call_args_list:
@@ -174,3 +201,122 @@ def test_blob_no_prefix(mock_storage, mock_makedirs):  # pylint: disable=unused-
     # then
     actual_calls = get_call_args(mock_container.download_blob.call_args_list)
     assert set(actual_calls) == set(expected_calls)
+
+
+@mock.patch('kserve.storage.os.makedirs')
+@mock.patch('kserve.storage.Storage._get_azure_storage_token')
+@mock.patch('kserve.storage.ShareServiceClient')
+def test_file_share(mock_storage, mock_get_token, mock_makedirs):  # pylint: disable=unused-argument
+
+    # given
+    file_share_path = 'https://kfserving.file.core.windows.net/triton/simple_string/'
+    mock_get_token.return_value = "some_token"
+
+    mock_file_share, mock_file, mock_data = create_mock_objects_for_file_share(
+        mock_storage, [[create_mock_dir('1'), create_mock_file('config.pbtxt')],
+                       [create_mock_file('model.graphdef')],
+                       []])
+
+    # when
+    kserve.Storage._download_azure_file_share(file_share_path, "dest_path")
+
+    # then
+    arg_list = get_call_args(mock_file.get_file_client.call_args_list)
+    assert set(arg_list) == set([('simple_string/1/model.graphdef',),
+                                 ('simple_string/config.pbtxt',)])
+
+    # then
+    mock_get_token.assert_called()
+    mock_storage.assert_called_with('https://kfserving.file.core.windows.net',
+                                    credential='some_token')
+
+
+@mock.patch('kserve.storage.os.makedirs')
+@mock.patch('kserve.storage.Storage._get_azure_storage_token')
+@mock.patch('kserve.storage.ShareServiceClient')
+def test_deep_file_share(mock_storage, mock_get_token, mock_makedirs):  # pylint: disable=unused-argument
+
+    file_share_path = 'https://accountname.file.core.windows.net/container/some/deep/blob/path'
+    paths = ['f1', 'f2', 'd1/f11', 'd1/d2/f21', 'd1/d2/d3/f1231', 'd4/f41']
+    fq_item_paths = ['some/deep/blob/path/' + p for p in paths]
+    expected_calls = [(f,) for f in fq_item_paths]
+    mock_get_token.return_value = "some_token"
+
+    # when
+    mock_file_share, mock_file, mock_data = create_mock_objects_for_file_share(
+        mock_storage, [[create_mock_dir('d1'), create_mock_dir('d4'), create_mock_file('f1'), create_mock_file('f2')],
+                       [create_mock_file('f41')],
+                       [create_mock_dir('d2'), create_mock_file('f11')],
+                       [create_mock_dir('d3'), create_mock_file('f21')],
+                       [create_mock_file('f1231')],
+                       []])
+    try:
+        kserve.Storage._download_azure_file_share(file_share_path, "some/dest/path")
+    except OSError:  # Permissions Error Handling
+        pass
+
+    # then
+    actual_calls = get_call_args(mock_file.get_file_client.call_args_list)
+    assert set(actual_calls) == set(expected_calls)
+
+    # then
+    mock_get_token.assert_called()
+    mock_storage.assert_called_with('https://accountname.file.core.windows.net',
+                                    credential='some_token')
+
+
+@mock.patch('kserve.storage.os.makedirs')
+@mock.patch('kserve.storage.Storage._get_azure_storage_token')
+@mock.patch('kserve.storage.ShareServiceClient')
+def test_file_share_fq_file(mock_storage, mock_get_token, mock_makedirs):  # pylint: disable=unused-argument
+
+    # given
+    file_share_path = 'https://accountname.file.core.windows.net/container/folder/'
+    paths = ['somefile.text']
+    fq_item_paths = ['folder/' + p for p in paths]
+    expected_calls = [(f,) for f in fq_item_paths]
+
+    # when
+    mock_get_token.return_value = "some_token"
+    mock_file_share, mock_file, mock_data = create_mock_objects_for_file_share(
+        mock_storage, [[create_mock_file('somefile.text')],
+                       []])
+    kserve.Storage._download_azure_file_share(file_share_path, "some/dest/path")
+
+    # then
+    actual_calls = get_call_args(mock_file.get_file_client.call_args_list)
+    assert actual_calls == expected_calls
+
+    # then
+    mock_get_token.assert_called()
+    mock_storage.assert_called_with('https://accountname.file.core.windows.net',
+                                    credential='some_token')
+
+
+@mock.patch('kserve.storage.os.makedirs')
+@mock.patch('kserve.storage.Storage._get_azure_storage_token')
+@mock.patch('kserve.storage.ShareServiceClient')
+def test_file_share_no_prefix(mock_storage, mock_get_token, mock_makedirs):  # pylint: disable=unused-argument
+
+    # given
+    file_share_path = 'https://accountname.file.core.windows.net/container/'
+    paths = ['somefile.text', 'somefolder/somefile.text']
+    fq_item_paths = ['' + p for p in paths]
+    expected_calls = [(f,) for f in fq_item_paths]
+
+    # when
+    mock_get_token.return_value = "some_token"
+    mock_file_share, mock_file, mock_data = create_mock_objects_for_file_share(
+        mock_storage, [[create_mock_dir('somefolder'), create_mock_file('somefile.text')],
+                       [create_mock_file('somefile.text')],
+                       []])
+    kserve.Storage._download_azure_file_share(file_share_path, "some/dest/path")
+
+    # then
+    arg_list = get_call_args(mock_file.get_file_client.call_args_list)
+    assert set(arg_list) == set(expected_calls)
+
+    # then
+    mock_get_token.assert_called()
+    mock_storage.assert_called_with('https://accountname.file.core.windows.net',
+                                    credential='some_token')