Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Fprintf by just Fprint #4

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented Apr 24, 2020

Description

Fixes eksctl-io/eksctl#836

Approach

This issue happens if the log message is have special character %. As we already performed formating in https://github.com/kris-nova/logger/blob/master/logger.go#L51, we don't need to use Fprintf again.

Note

I also take this chance to add go.mod file for this library as well

@sayboras
Copy link
Contributor Author

@kris-nova for your input and review once you have time, thanks a lot 👍

@martina-if
Copy link

Hi @kris-nova , we use this fantastic logger in eksctl and would love to have this small fix. Can you please take a look when you have some time?

@krisnova krisnova merged commit 8e2d9fd into krisnova:master Feb 14, 2021
@krisnova
Copy link
Owner

Hey sorry i literally just saw this

Please let me know who else I can make a maintainer here so they can have merge access (twitter or kubernetes slack... or most folks at AWS know how to get a hold of me)

I will be pushing some changes soon - and I will add these tests to the 2.0 release to make sure we preserve backwards compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eksctl aws logging includes bizarre (MISSING) replacements
3 participants