Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MISSING replacement in log with verbose >= 5 #2084

Closed
wants to merge 1 commit into from

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented Apr 24, 2020

Description

Fixes #836

PR krisnova/logger#4 is raised in upstream repo. Currently, I am using my forked repo for testing purpose.

Testing

Before the changes:

$ ./eksctl create cluster --managed --node-private-networking --verbose 5 > create_cluster_fixed.lo
$ grep -is MISSING create_cluster.log | wc -l           
54

After the changes:

$ ./eksctl create cluster --managed --node-private-networking --verbose 5 > create_cluster_fixed.log
$ grep -is MISSING create_cluster_fixed.log | wc -l
0

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@sayboras sayboras changed the title Add format in aws custom logging Fix MISSING in log with verbose >= 5 Apr 24, 2020
@sayboras sayboras force-pushed the feature/logging-verbose branch from 8817c98 to 1cc4929 Compare April 24, 2020 11:48
@sayboras sayboras changed the title Fix MISSING in log with verbose >= 5 Fix MISSING replacement in log with verbose >= 5 Apr 24, 2020
@sayboras sayboras force-pushed the feature/logging-verbose branch 6 times, most recently from 161489c to f5f8359 Compare May 1, 2020 11:08
@sayboras sayboras force-pushed the feature/logging-verbose branch 2 times, most recently from 14c0769 to a651f90 Compare May 15, 2020 10:19
@sayboras sayboras force-pushed the feature/logging-verbose branch from f3d247b to 8568e1e Compare May 20, 2020 14:32
@martina-if
Copy link
Contributor

I asked the maintainer for a review... let's see if we can get that merged.

@sayboras sayboras force-pushed the feature/logging-verbose branch 3 times, most recently from f2c5238 to 248287a Compare May 21, 2020 11:59
@sayboras sayboras force-pushed the feature/logging-verbose branch from 248287a to 12d1534 Compare May 25, 2020 12:33
@michaelbeaumont
Copy link
Contributor

@sayboras thanks for the contribution!
given that kris-nova/logger doesn't seem to be maintained, we've decided we'd prefer a more common, better maintained library rather than forking the current logger.

@sayboras sayboras deleted the feature/logging-verbose branch May 26, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eksctl aws logging includes bizarre (MISSING) replacements
3 participants