Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rules for migration to Hibernate 5.6 #206

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Create rules for migration to Hibernate 5.6 #206

merged 4 commits into from
Jan 16, 2025

Conversation

jayfray12
Copy link
Contributor

  • Create rule to detect javassist
  • Create rule to detect use of type CLOB in PostgresSQL81Dialect

These were the only 2 items found in the hibernate migration guide

@jayfray12
Create rules for migration to Hibernate 5.6 konveyor#166
a5e6c8d 
Signed-off-by: Jason Froehlich <jfroehlich12@gmail.com>
@jayfray12
Create rules for migration to Hibernate 5.6 konveyor#166
b04e714 
Signed-off-by: Jason Froehlich <jfroehlich12@gmail.com>
@jayfray12 jayfray12 requested a review from jmle December 20, 2024 17:29
@jayfray12 jayfray12 mentioned this pull request Dec 20, 2024
Open
jmle
jmle requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@jmle jmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor requests

default/generated/spring-framework/spring-framework-5.x-to-6.0-data-access.yaml Show resolved Hide resolved
default/generated/spring-framework/spring-framework-5.x-to-6.0-data-access.yaml Outdated Show resolved Hide resolved
default/generated/spring-framework/spring-framework-5.x-to-6.0-data-access.yaml Outdated Show resolved Hide resolved
default/generated/spring-framework/spring-framework-5.x-to-6.0-data-access.yaml Outdated Show resolved Hide resolved
default/generated/spring-framework/spring-framework-5.x-to-6.0-data-access.yaml Show resolved Hide resolved
@jayfray12
konveyor#166 updated based on PR comments (removed as, added java.dep…
5e52ba7 
…endency, and more detail in the message)

Signed-off-by: Jason Froehlich <jfroehlich12@gmail.com>
@jayfray12
konveyor#166 Added changes to make rules more robust
816c7e5 
Signed-off-by: Jason Froehlich <jfroehlich12@gmail.com>
@jmle jmle self-requested a review January 16, 2025 08:51
@jmle jmle merged commit 34adb1d into konveyor:main Jan 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmle jmle jmle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayfray12 @jmle