Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rules for migration to Hibernate 5.6 #166

Open
jmle opened this issue Nov 7, 2024 · 5 comments
Open

Create rules for migration to Hibernate 5.6 #166

jmle opened this issue Nov 7, 2024 · 5 comments
Assignees
@jayfray12
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. spring-migration/6 Label for Spring Migration path 5 -> 6 spring-migration/6.0 Label for Spring Migration path 5.x -> 6.0

Comments

@jmle
Copy link
Contributor

jmle commented Nov 7, 2024

As part of the migration to Spring 6, there is a minimum requirement of Hibernate 5.6. We don't currently have the rules for that migration, so we should create them.

See the migration guide
@jmle jmle added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. spring-migration/6 Label for Spring Migration path 5 -> 6 spring-migration/6.0 Label for Spring Migration path 5.x -> 6.0 labels Nov 7, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 7, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. label Nov 7, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Nov 7, 2024
@jmle jmle moved this from 🆕 New to 📋 Backlog in Planning Nov 18, 2024
@srummel
Copy link

srummel commented Dec 17, 2024

I would like to work on this issue

@jayfray12 jayfray12 self-assigned this Dec 19, 2024
@jayfray12 jayfray12 moved this from 🔖 Ready to 🏗 In progress in Planning Dec 19, 2024
jayfray12 added a commit to jayfray12/rulesets that referenced this issue Dec 20, 2024
@jayfray12
Create rules for migration to Hibernate 5.6 konveyor#166
a5e6c8d 
Signed-off-by: Jason Froehlich <jfroehlich12@gmail.com>
jayfray12 added a commit to jayfray12/rulesets that referenced this issue Dec 20, 2024
@jayfray12
Create rules for migration to Hibernate 5.6 konveyor#166
b04e714 
Signed-off-by: Jason Froehlich <jfroehlich12@gmail.com>
@jayfray12
Copy link
Contributor

Created 2 rules based on the hibernate migration guide.
PR found here: #206

@jayfray12
Copy link
Contributor

Juanma commented on PR. Will be addressing these comments soon

jayfray12 added a commit to jayfray12/rulesets that referenced this issue Jan 13, 2025
@jayfray12
konveyor#166 updated based on PR comments (removed as, added java.dep…
5e52ba7 
…endency, and more detail in the message)

Signed-off-by: Jason Froehlich <jfroehlich12@gmail.com>
@jayfray12
Copy link
Contributor

Comments addressed waiting on re-review

jayfray12 added a commit to jayfray12/rulesets that referenced this issue Jan 15, 2025
@jayfray12
konveyor#166 Added changes to make rules more robust
816c7e5 
Signed-off-by: Jason Froehlich <jfroehlich12@gmail.com>
jmle pushed a commit that referenced this issue Jan 16, 2025
@jayfray12 @jmle
Create rules for migration to Hibernate 5.6 #166
3c4b31e 
Signed-off-by: Jason Froehlich <jfroehlich12@gmail.com>
jmle pushed a commit that referenced this issue Jan 16, 2025
@jayfray12 @jmle
Create rules for migration to Hibernate 5.6 #166
cbebb7c 
Signed-off-by: Jason Froehlich <jfroehlich12@gmail.com>
jmle pushed a commit that referenced this issue Jan 16, 2025
@jayfray12 @jmle
#166 updated based on PR comments (removed as, added java.dependency,…
37280b4 
… and more detail in the message)

Signed-off-by: Jason Froehlich <jfroehlich12@gmail.com>
jmle pushed a commit that referenced this issue Jan 16, 2025
@jayfray12 @jmle
#166 Added changes to make rules more robust
34adb1d 
Signed-off-by: Jason Froehlich <jfroehlich12@gmail.com>
@jayfray12 jayfray12 moved this from 🏗 In progress to ✅ Done in Planning Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayfray12 jayfray12

Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. spring-migration/6 Label for Spring Migration path 5 -> 6 spring-migration/6.0 Label for Spring Migration path 5.x -> 6.0
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srummel @jmle @jayfray12 @danisanchez001