Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(STONEINTG-698): remove ephemeral environment references #182

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat(STONEINTG-698): remove ephemeral environment references #182

merged 1 commit into from
Sep 23, 2024

Conversation

dirgim
Copy link
Contributor

@dirgim dirgim commented Apr 25, 2024

  • Remove all references to ephemeral environments from the integration service architecture document

arewm
arewm previously requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that there are some references to environments in the diagrams/images. Can you also remove those?

Note: this will likely conflict with #180 if that is merged first.

@dirgim
Copy link
Contributor Author

dirgim commented Apr 25, 2024

I believe that there are some references to environments in the diagrams/images. Can you also remove those?

Note: this will likely conflict with #180 if that is merged first.

I'm planning to have a follow-up PR to update the integration service diagram to a new format since Lucid Charts (where the original diagram was made) are not available anymore.

@ralphbean ralphbean added the kind/feat Something new label Apr 30, 2024
jsztuka
jsztuka approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@jsztuka jsztuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, needs rebase.

@ralphbean
Copy link
Member

LGTM. @dirgim do you have rights to merge?

@hongweiliu17 hongweiliu17 mentioned this pull request May 26, 2024
Merged
@dirgim
feat(STONEINTG-698): remove ephemeral environment references
2feef70 
* Remove all references to ephemeral environments from
  the integration service architecture document

Signed-off-by: dirgim <kpavic@redhat.com>
@dirgim
Copy link
Contributor Author

dirgim commented May 31, 2024 •
edited
Loading

@arewm are you ok with the current changes included here? The environment references have already been removed from the existing diagrams in previous PR.

@dirgim dirgim requested a review from arewm June 25, 2024 08:52
@dirgim dirgim dismissed arewm’s stale review August 19, 2024 07:51

The requested changes were already done as part of a different PR, and all conflicts have been resolved.

@arewm arewm merged commit 8172904 into konflux-ci:main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsztuka jsztuka jsztuka approved these changes

@kasemAlem kasemAlem kasemAlem approved these changes

@hongweiliu17 hongweiliu17 hongweiliu17 approved these changes

@arewm arewm arewm approved these changes

@ralphbean ralphbean ralphbean approved these changes

@MartinBasti MartinBasti Awaiting requested review from MartinBasti

@14rcole 14rcole Awaiting requested review from 14rcole

@Josh-Everett Josh-Everett Awaiting requested review from Josh-Everett

Assignees
No one assigned
Labels
kind/feat Something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dirgim @ralphbean @arewm @hongweiliu17 @kasemAlem @jsztuka