Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace most mentions of AppStudio with Konflux #180

Merged
merged 1 commit into from
May 2, 2024
Merged

Replace most mentions of AppStudio with Konflux #180

merged 1 commit into from
May 2, 2024

Conversation

ralphbean
Copy link
Member

No description provided.

@ralphbean ralphbean enabled auto-merge April 23, 2024 23:38
@arewm
Copy link
Member

arewm commented Apr 24, 2024

Do you want to change the relevant file names or references within the images as well?

@ralphbean
Copy link
Member Author

@arewm hm, yes. Let's do that here.

@arewm arewm mentioned this pull request Apr 25, 2024
Merged
@ralphbean
Copy link
Member Author

@arewm I updated to include diagram changes now and a few filename changes too.

arewm
arewm approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust what you have done and won't double-check it. We can continue to replace references as we discover them.

@ralphbean ralphbean requested a review from a team April 30, 2024 14:29
@ralphbean ralphbean added the kind/chore Something non-functional that just needs to get done label Apr 30, 2024
dirgim
dirgim approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ralphbean ralphbean merged commit bebef38 into main May 2, 2024
@ralphbean ralphbean deleted the konflux-ci branch May 2, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirgim dirgim dirgim approved these changes

@arewm arewm arewm approved these changes

Assignees
No one assigned
Labels
kind/chore Something non-functional that just needs to get done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralphbean @arewm @dirgim