Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: massmint not checking balance when minting #11188

Merged
merged 8 commits into from
Nov 27, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Nov 26, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

take minting cost (itemDeposit and a base transaction fee) into consideration

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-11-27 at 11 01 49@2x

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2f214aa
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6747053df736e200082fff15
😎 Deploy Preview https://deploy-preview-11188--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian marked this pull request as ready for review November 27, 2024 06:02
@hassnian hassnian requested a review from a team as a code owner November 27, 2024 06:02
@hassnian hassnian requested review from preschian and vikiival and removed request for a team November 27, 2024 06:02
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise amaziiiing!

const isMinting = ref(false)
const mintStatus = ref('')

const neededAmount = computed(() => (itemDeposit.value * Object.keys(NFTS.value).length) + transactionFee.value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either add metada deposit into calculation or 10% premium
(neededAmount * 1.1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 50f1f41

@vikiival vikiival enabled auto-merge November 27, 2024 10:06
@vikiival vikiival disabled auto-merge November 27, 2024 11:40
@vikiival vikiival merged commit 1d9b58c into kodadot:main Nov 27, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Massmint not checking balance
2 participants