Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massmint not checking balance #11189

Closed
hassnian opened this issue Nov 27, 2024 · 1 comment · Fixed by #11188
Closed

Massmint not checking balance #11189

hassnian opened this issue Nov 27, 2024 · 1 comment · Fixed by #11188
Assignees
Labels
A-mass-mint issues related to mass mint bug Something isn't working p1 preventing everyone from using app

Comments

@hassnian
Copy link
Contributor

hassnian commented Nov 27, 2024

a couple of weeks ago patricia was having issues mass-minting a large amount of NFTs

apparently she had enough funds on-chain but she could not mint (transaction would fail), after checking her address she did not have funds on AHP after transferring funds to her wallet everything worked.

that's how I found that the massmint does not check the user balance at all

it should

  1. take minting cost (itemDeposit and a base transaction fee) into consideration
  2. ideally support auto-teleport

Originally posted by @hassnian in #11188 (comment)

@hassnian hassnian self-assigned this Nov 27, 2024
@hassnian hassnian added p1 preventing everyone from using app A-mass-mint issues related to mass mint bug Something isn't working labels Nov 27, 2024
@vikiival
Copy link
Member

1a. It should also take metadata deposit into consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mass-mint issues related to mass mint bug Something isn't working p1 preventing everyone from using app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants