Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: early success in offer modals #10997

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Sep 18, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

all offer modals (create, cancel, accept) now use the correct flow of signing and notification with early success once the transaction is in block

cc @exezbcz visual ok plz

Screenshot 📸

  • My fix has changed something on UI;
CleanShot.2024-09-18.at.14.09.12.mp4

@hassnian hassnian requested a review from a team as a code owner September 18, 2024 09:12
Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 76aba7a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66ebef83953430000891ed99
😎 Deploy Preview https://deploy-preview-10997--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian changed the title fix: what takes so long to create offer feat: early success in offer modals Sep 18, 2024
@exezbcz
Copy link
Member

exezbcz commented Sep 18, 2024

quick and easy, nice

image image

@hassnian hassnian added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Sep 19, 2024
@vikiival vikiival added this pull request to the merge queue Sep 19, 2024
Merged via the queue into kodadot:main with commit 0a367cc Sep 19, 2024
1 of 3 checks passed
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

what takes so long to create offer
5 participants