Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what takes so long to create offer #10952

Closed
exezbcz opened this issue Sep 9, 2024 · 4 comments · Fixed by #10997
Closed

what takes so long to create offer #10952

exezbcz opened this issue Sep 9, 2024 · 4 comments · Fixed by #10997
Assignees

Comments

@exezbcz
Copy link
Member

exezbcz commented Sep 9, 2024

image

waiting at least 40 seconds for offer to be created is quite a lot

@exezbcz
Copy link
Member Author

exezbcz commented Sep 9, 2024

cc @hassnian @Jarsen136

@hassnian
Copy link
Contributor

hassnian commented Sep 10, 2024

@exezbcz atm it's waiting for the transaction to be finalized, we can show the success state once the transaction is in block

but the offer wont be shown in the page immediately after the transaction is 'completed'

we would still need something like this

CleanShot 2024-09-10 at 11 24 56@2x

@exezbcz
Copy link
Member Author

exezbcz commented Sep 10, 2024

we would still need something like this

yeah that looks good, let me iterate the design and do that

@exezbcz
Copy link
Member Author

exezbcz commented Sep 17, 2024

ups, forgot to post

image

its next to the offer infographics

  • copy changed a bit and added small contextual message

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants