Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minted count #10903

Merged
merged 40 commits into from
Sep 10, 2024
Merged

fix: minted count #10903

merged 40 commits into from
Sep 10, 2024

Conversation

preschian
Copy link
Member

@preschian preschian commented Aug 26, 2024

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

tldr; #10903 (comment)

Did your issue had any of the "$" label on it?

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8f1ce5e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66e0143af262ad00081e1269
😎 Deploy Preview https://deploy-preview-10903--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Aug 26, 2024

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8f1ce5e
Status: ✅  Deploy successful!
Preview URL: https://6d7c9a81.kodaart-production.pages.dev
Branch Preview URL: https://refactor--unused-drops-compo.kodaart-production.pages.dev

View logs

@preschian preschian changed the title refactor: some unused drops component fix: minted count Aug 27, 2024
@preschian preschian marked this pull request as ready for review August 27, 2024 08:58
@preschian preschian requested a review from a team as a code owner August 27, 2024 08:58
@preschian preschian requested review from vikiival and hassnian and removed request for a team August 27, 2024 08:58
@preschian
Copy link
Member Author

It may not be related to this issue.

After I minted a drop, the number of minted does not update. I have to refresh the page to see the correct number.

this is really good point and related to this PR
hopefully it can clear the issue if we add popup message like this. let me ask Exec first (the popup is from fxhash)

E62CB9F8-22F0-4C48-A10C-D78BF7BA8A35_1_105_c

@preschian
Copy link
Member Author

preschian commented Sep 9, 2024

Changes:

  • Adjust carousel drops to align with ops-internal discussion #1845. Additionally, show minted drops on the carousel. Because, if all of the drops already minted out, it will shows blank
  • Remove useDrops() composable. Use getDrops() directly.
  • Replace useCollectionActivity() usage with oda-worker to get owner address on DropCard related components:
    • Reason: useCollectionActivity() composable is computationally heavy on the client side.
    • Impact: When switching chains, it was noticeably laggy on localhost.
  • Add toast message when claiming drops is successful:
    • Purpose: To provide more information to users about the delay in seeing the drops on the website.
    • Reference: PR #10903 comment
  • Remove drop.location usage:
    • Rationale: Seems to be rarely used. Can be added back if needed in the future.
  • Refactor some useDrops() composable to drops/utils.ts
  • Remove Drop interface, adjust DropItem instead
  • Remove unused Unlockable components

@preschian preschian requested a review from hassnian September 9, 2024 07:48
@vikiival
Copy link
Member

vikiival commented Sep 9, 2024

cc @Jarsen136

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@vikiival
Copy link
Member

remedy for - #10958

Copy link

@vikiival vikiival added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit a80c5b9 Sep 10, 2024
20 of 23 checks passed
@vikiival vikiival deleted the refactor--unused-drops-component branch September 10, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants