fix: initial data load in useSubscriptionGraphql #10925
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
| if (lastQueryResult !== null) { | ||
| $consola.log(`[Graphql Subscription] New changes: ${JSON.stringify(newResult)}`) | ||
| onChange({ data: newResult }) | ||
| } |
There was a problem hiding this comment.
this is not how the old implementation of useSubscriptionGraphql.ts worked
onChange was triggered when fetching also for the first time
seeBuy.vue how it's clear that it depends on the first fetch to also trigger onChange, with this change the buy modal never loads
if for some reason you want this behaviour i would make it optional as. param, when needed, otherwise you might be breaking other code
on a similar note atm the polling waits 6 seconds before making the first fetch, I'd just fix that on this pr
from #10911, pls suggest if you have any better fix :)
There was a problem hiding this comment.
Well, originally it was supposed to be used to monitor upcoming changes. Since there is a need to trigger the first request, let's keep it as it is.
Thanks for your explanation.
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
For the composable
useSubscriptionGraphql, the initial data fetching should not triggeronChangecallback