Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Offers tab in profile and gallery item #10911

Merged
merged 43 commits into from
Sep 9, 2024
Merged

feat: Offers tab in profile and gallery item #10911

merged 43 commits into from
Sep 9, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Aug 27, 2024 •
edited
Loading

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

test: https://deploy-preview-10911--koda-canary.netlify.app/ahp/gallery/166-2408213503

Needs Design check

Screenshot 📸

  • My fix has changed something on UI;

Gallery Item

Profile detail

CleanShot 2024-08-31 at 17 57 18@2x

Cancel Offer

CleanShot 2024-08-31 at 18 00 41@2x

Accept Offer

CleanShot 2024-08-31 at 18 01 24@2x

@netlify Netlify
Copy link

netlify bot commented Aug 27, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 00d13ba
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66ded33fd559c600087f07a3
😎 Deploy Preview https://deploy-preview-10911--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian changed the title feat: Offers tab in gallery item & offer cancel / accept feat: Offers tab with cancel and accept Aug 28, 2024
@hassnian hassnian marked this pull request as ready for review August 31, 2024 12:57
@hassnian hassnian requested a review from a team as a code owner August 31, 2024 12:57
@hassnian hassnian mentioned this pull request Sep 2, 2024
Closed
1 task
@hassnian hassnian requested a review from Jarsen136 September 3, 2024 10:37
Jarsen136
Jarsen136 reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the third row of offers, the time looks incorrect. 17.08 (16 days ago?)
seems like an indexer issue, query is ok, and that offer should be EXPIRED

image I mean the days look confusing and it can't tell whether it's the future or the past Is it possible to show the relative time of the offer? like (16 days ago) , (in 3 days)

@hassnian
Copy link
Contributor Author

hassnian commented Sep 3, 2024

I mean the days look confusing and it can't tell whether it's the future or the past Is it possible to show the relative time of the offer? like (16 days ago) , (in 3 days)

I did talk with @exezbcz about this and he wanted it without the "in x days" just "x days", added time ago if the offer is expired

@hassnian hassnian changed the title feat: Offers tab with cancel and accept feat: Offers tab in profile and gallery item with cancel and accept Sep 3, 2024
@hassnian hassnian changed the title feat: Offers tab in profile and gallery item with cancel and accept feat: Offers tab in profile and gallery item Sep 3, 2024
@Jarsen136
Copy link
Contributor

  1. At the third row of offers, the time looks incorrect. 17.08 (16 days ago?)

seems like an indexer issue, query is ok, that offer should be EXPIRED cc @vikiival

I'm waiting for the confirmation about the EXPIRED status.

Otherwise lgtm

@vikiival vikiival mentioned this pull request Sep 4, 2024
Closed
@vikiival
Copy link
Member

vikiival commented Sep 4, 2024

Yup it is a bug

@vikiival
Copy link
Member

vikiival commented Sep 9, 2024

Screenshot 2024-09-09 at 09 08 14

Hey, seems like a lot of tests is failing on this PR

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@hassnian hassnian added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Sep 9, 2024
@hassnian
Copy link
Contributor Author

hassnian commented Sep 9, 2024

Hey, seems like a lot of tests is failing on this PR

fixed tests related to this pr

@vikiival vikiival added this pull request to the merge queue Sep 9, 2024
Merged via the queue into kodadot:main with commit 9fd91c4 Sep 9, 2024
20 of 22 checks passed
This was referenced Sep 9, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5. Manage offers on profile page 4. cancel / accept offer 3. Offers tab in gallery item
4 participants
@hassnian @Jarsen136 @vikiival @preschian