Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _validation_status to exports; closes #1851 #2038

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Add _validation_status to exports; closes #1851 #2038

merged 3 commits into from
Oct 23, 2018

Conversation

jnm
Copy link
Member

@jnm jnm commented Oct 23, 2018

Also improves handling of formpack UNTRANSLATED and UNSPECIFIED_TRANSLATION
constants; closes #2037

jnm added 2 commits October 23, 2018 01:25
@jnm
Update formpack for ValidationStatusCopyField
669b825
@jnm
Add _validation_status to exports; closes #1851
6d744cf 
Also improves handling of formpack `UNTRANSLATED` and `UNSPECIFIED_TRANSLATION`
constants; closes #2037
@jnm jnm requested a review from noliveleger October 23, 2018 05:33
@jnm jnm mentioned this pull request Oct 23, 2018
Closed
@noliveleger
Copy link
Contributor

@jnm, FYI your changes are fine but few tests were failed because of the lack of validation_status field. I've fixed them before merging.

@noliveleger noliveleger merged commit 432f098 into master Oct 23, 2018
@noliveleger noliveleger deleted the 1851-export-validation-statuses branch October 23, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noliveleger noliveleger Awaiting requested review from noliveleger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnm @noliveleger