Make export constants consistent with FormPack - fix #2037
Conversation
…stead of 'xml' to backend when choosing 'XML values and headers'
| used for labels. Leave unset, or use `_default` or `None`, for | ||
| labels in the default language | ||
| * `lang`: optional; It can be: | ||
| - unset (`None`) or `formpack.constants.UNTRANSLATED` for labels in the default language (default: `None`). |
There was a problem hiding this comment.
I try to keep lines under 80 characters for readability. It can certainly be a pain sometimes.
Is there a docstring parser you like to use that doesn't handle line breaks within these parameter descriptions well?
There was a problem hiding this comment.
@jnm , I kept the default of my IDE which is 120 characters instead of 80. Nowadays, screen resolutions are wider than before. 80 is really narrow, but if you want me to go with 80. I will.
| // Backend also changes `_xml` to `FormPack.constant.UNSPECIFIED_TRANSLATION` | ||
| // `FormPack.constant.UNSPECIFIED_TRANSLATION` constant equals `False`. | ||
| else if (lang === '_xml' || lang === false) { | ||
| langDescription = t('XML values and headers'); |
There was a problem hiding this comment.
Admirable, but this wraps onto a second line:
Also, for every language it's the values and headers, but we probably wouldn't want to say English (en) values and headers either.
There was a problem hiding this comment.
What's the suggestion? Only XML in caps?
I've seen your change. Sounds good.
Also improves handling of formpack `UNTRANSLATED` and `UNSPECIFIED_TRANSLATION` constants; closes #2037
Fixed #2030.