Experimental: don't URL-encode Postman query parameters (closes #442)

knuckleswtf · Mar 19, 2023 · df4d86f · df4d86f
1 parent ea34186
commit df4d86f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Writing/PostmanCollectionWriter.php b/src/Writing/PostmanCollectionWriter.php
@@ -293,8 +293,8 @@ protected function generateUrlObject(OutputEndpointData $endpointData): array
                     // Going with the first to also support object query parameters
                     // See https://www.php.net/manual/en/function.parse-str.php
                     $query[] = [
-                        'key' => urlencode("{$name}[$index]"),
-                        'value' => urlencode($value),
+                        'key' => "{$name}[$index]",
+                        'value' => $value,
                         'description' => strip_tags($parameterData->description),
                         // Default query params to disabled if they aren't required and have empty values
                         'disabled' => !$parameterData->required && empty($parameterData->example),

diff --git a/tests/Unit/PostmanCollectionWriterTest.php b/tests/Unit/PostmanCollectionWriterTest.php
@@ -130,13 +130,13 @@ public function query_parameters_are_documented()
             'disabled' => false,
         ], $variableData[0]);
         $this->assertEquals([
-            'key' => urlencode('filters[0]'),
+            'key' => 'filters[0]',
             'value' => '34',
             'description' => 'Filters',
             'disabled' => false,
         ], $variableData[1]);
         $this->assertEquals([
-            'key' => urlencode('filters[1]'),
+            'key' => 'filters[1]',
             'value' => '12',
             'description' => 'Filters',
             'disabled' => false,