-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postman Collection Where Example contains a colon #442
Comments
I'll consider it, but I think I once removed it, but returned it when that caused problems. |
We have the same problem, for example, this filter is corrupted in the postman collection but not open API. |
@shalvah same issue here! Are there any updates? |
Ugh, I can see that I reverted it, but I can't find the reason why. I'll change it for now, and let's see. My hypothesis is that there are more non-URL-friendly characters beyond the |
What happened?
/**
*@QueryParam identifier required foobar. Example: 1234:1234
*/
php artisan scribe:generate
..."query": [
{
"key": "identifier",
"value": "1234%3A1234",
"description": "foobar",
"disabled": false
}
],
instead of...
"query": [
{
"key": "identifier",
"value": "1234:1234",
"description": "foobar",
"disabled": false
}
],
My environment:
composer show laravel/framework
orcomposer show laravel/lumen-framework
): 9.1composer show knuckleswtf/scribe
): 3.24Additional info:
I've tracked this done to the class PostmanCollectionWriter.php::generateUrlObject[line:252 + 261]
'value' => urlencode($parameterData->example),
I think this should be as follows because the value doesn't need escaping here as postman escapes the values when it processes the url parameters:
'value' => $parameterData->example,
The text was updated successfully, but these errors were encountered: