Bump cert-manager and use their clientset

[skonto]

Proposed Changes

• Similar to bump istio and use their clientsets knative-extensions/net-istio#1399

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.82%. Comparing base (fe0e53f) to head (82b465c).

Files with missing lines	Patch %	Lines
pkg/queue/sharedmain/handlers.go	0.00%	1 Missing ⚠️
pkg/reconciler/route/route.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15703      +/-   ##
==========================================
- Coverage   80.85%   80.82%   -0.04%     
==========================================
  Files         222      222              
  Lines       18035    18037       +2     
==========================================
- Hits        14583    14578       -5     
- Misses       3082     3088       +6     
- Partials      370      371       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[skonto]

Without this I am hitting kubernetes/code-generator#177 cc @dprotaso

[dprotaso]

you don't need the version in the first part of the replace directive

[skonto]

  only new issues on pull_request: 
  Running [/home/runner/golangci-lint-1.62.2-linux-amd64/golangci-lint run  --go=1.23] in [/home/runner/work/serving/serving] ...
  Error: pkg/activator/handler/handler.go:160:36: response body must be closed (bodyclose)
  			rc := http.NewResponseController(w)
  			                                ^
  Error: pkg/queue/protobuf_stats_reporter_test.go:141:20: response body must be closed (bodyclose)
  	result := w.Result()
  	                  ^
  Error: pkg/queue/sharedmain/handlers.go:135:35: response body must be closed (bodyclose)
  		rc := http.NewResponseController(w)
  		                                ^
  Error: pkg/reconciler/route/route.go:372:3: error is not nil (line 370) but it returns nil (nilerr)
  		return nil, nil
  		^
  4 issues:
  * bodyclose: 3
  * nilerr: 1
  * ```

[skonto]

I will fix the lint thing although it is irrelevant to the PR it seems 🤔

[skonto]

Looking at the lint errors:

$/golangci-lint-1.62.2-linux-amd64/golangci-lint run
pkg/activator/handler/handler.go:160:36: response body must be closed (bodyclose)
			rc := http.NewResponseController(w)
			                                ^
pkg/queue/sharedmain/handlers.go:135:35: response body must be closed (bodyclose)
		rc := http.NewResponseController(w)
		                                ^
2 issues:
* bodyclose: 2
$/golangci-lint-1.63.4-linux-amd64/golangci-lint run
0 issues. (edited) 

Probably we need to update the action to the latest because this seems like a false positive.

Btw when we bump the linter version we will face issues like:

$golangci-lint-1.63.4-linux-amd64/golangci-lint run 
pkg/activator/handler/handler.go:160:4: directive `//nolint:bodyclose` is unused for linter "bodyclose" (nolintlint)
			//nolint:bodyclose
			^
1 issues:
* nolintlint: 1

Unlike 1.62.2 1.63.4 does not like the directives there.

cc @dprotaso

[skonto]

@dprotaso ready

[dprotaso]

1.63.4 does not like the directives there.

those seem like false positives (are they?) - my guess is they fixed a false positive in a newer version. I'd rather pick up the updated linter

Can we bump the linter version in knative/actions?

https://github.com/knative/actions/blob/4ffb84b92b706397651e63fbad1e628b67705507/.github/workflows/reusable-helper-go-style.yaml#L87

[dprotaso]

I bumped the linter here - knative/actions#243

[dprotaso]

Can you undo this nolint directive. I left this unfixed in an earlier PR so I could double check why we're not handling this scenario

[dprotaso]

We can do an override to get passed this lint failure for this PR and deal with it in a follow up