Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump istio and use their clientsets #1399

Merged

Conversation

dprotaso
Copy link
Contributor

  • bump to istio 1.24.2
  • stop generating our own istio clientset, informers and listers - use upstream
  • update knative injection codegen to use istio clienset etc.

@knative-prow knative-prow bot requested review from cardil, skonto and upodroid January 16, 2025 16:27
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 16, 2025
@dprotaso
Copy link
Contributor Author

/assign @skonto

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.42%. Comparing base (21d44ac) to head (55ab141).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1399      +/-   ##
==========================================
+ Coverage   80.22%   80.42%   +0.19%     
==========================================
  Files          25       25              
  Lines        2028     2023       -5     
==========================================
  Hits         1627     1627              
+ Misses        305      300       -5     
  Partials       96       96              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso dprotaso changed the title bump istio and use their cliensets bump istio and use their clientsets Jan 16, 2025
@skonto
Copy link
Contributor

skonto commented Jan 17, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
Copy link

knative-prow bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 04e673a into knative-extensions:main Jan 17, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants