Create a dedicated helper for retrying API calls during tests. #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an expansion of the workaround that vaikas initially added to address knative/test-infra#2346, however, a few new error types have emerged, which this will retry.
mattmoor
commented
Sep 9, 2020
| "k8s.io/client-go/util/retry" | ||
| ) | ||
|
|
||
| // RetryUpdateConflicts retries the inner function if it returns conflict errors. | ||
| // This can be used to retry status updates without constantly reenqueuing keys. | ||
| func RetryUpdateConflicts(updater func(int) error) error { | ||
| return RetryErrors(updater, apierrs.IsConflict) |
There was a problem hiding this comment.
Note that this is effectively the definition of retry.RetryOnConflict today.
n3wscott
reviewed
Sep 9, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an expansion of the workaround that vaikas initially added to address knative/test-infra#2346, however, a few new error types have emerged, which this will retry.