Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flaky] test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_and_extension_triggers #4208

Closed
knative-test-reporter-robot opened this issue Oct 4, 2020 · 4 comments
Labels
area/test-and-release Test infrastructure, tests or release auto:flaky kind/good-first-issue Denotes an issue ready for a new contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone

Comments

@knative-test-reporter-robot

Auto-generated issue tracking flakiness of test

  • Test name: test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_and_extension_triggers
  • Repository name: eventing
@knative-test-reporter-robot
Copy link
Author

knative-test-reporter-robot commented Oct 4, 2020

Latest result for this test: Passed
Last build start time: 2020-10-06 08:59:59 +0000 UTC
Failed 0 times out of 10 runs.

2020-10-06 08:59:59 +0000 UTC:
2020-10-05 08:55:19 +0000 UTC:
2020-10-04 08:54:05 +0000 UTC:

✔ Passed ✖ Failed ◻ Skipped

@lberk lberk added area/test-and-release Test infrastructure, tests or release priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Oct 5, 2020
@lberk lberk added this to the v0.19.0 milestone Oct 5, 2020
@vaikas
Copy link
Contributor

vaikas commented Oct 6, 2020

I think we need to update our retry logic, iirc, something changed with the way GKE reports their errors for quotas?

=== CONT  TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_and_extension_triggers
    creation.go:329: Creating v1beta1 trigger trigger-testany-testany--extname1-testany
    creation.go:717: Failed to configure pod "dumper-testany-source1--extname1-extval1": Operation cannot be fulfilled on resourcequotas "gke-resource-quotas": StorageError: invalid object, Code: 4, Key: /registry/resourcequotas/test-default-broker-with-many-triggers-test-default-brokermxl9x/gke-resource-quotas, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: 53616ba9-5e6b-4040-a7cc-02b0b4ed2f78, UID in object meta: 
    test_runner.go:196: EVENT: {{ } {default-trigger-testany-testany69f5a86f53fac2452763a994c2f4a117.163a8656ea7f0fe6  test-default-broker-with-many-triggers-test-default-brokermxl9x /api/v1/namespaces/test-default-broker-with-many-triggers-test-default-brokermxl9x/events/default-trigger-testany-testany69f5a86f53fac2452763a994c2f4a117.163a8656ea7f0fe6 9f07503f-88fc-40ad-9862-ce3531155acd 846 0 2020-10-03 15:52:05 +0000 UTC <nil> <nil> map[] map[] [] []  []} {Subscription test-default-broker-with-many-triggers-test-default-brokermxl9x default-trigger-testany-testany69f5a86f53fac2452763a994c2f4a117 700e44bf-280b-482e-9917-aab557af1c39 messaging.knative.dev/v1 5646 } FinalizerUpdate Updated "default-trigger-testany-testany69f5a86f53fac2452763a994c2f4a117" finalizers {subscription-controller } 2020-10-03 15:52:05 +0000 UTC 2020-10-03 15:52:05 +0000 UTC 1 Normal 0001-01-01 00:00:00 +0000 UTC nil  nil  }
111

@vaikas
Copy link
Contributor

vaikas commented Oct 6, 2020

Yeah... So, we basically need to switch our retry helpers to use this instead so it's all in one place.
knative/pkg#1695

@vaikas vaikas added the kind/good-first-issue Denotes an issue ready for a new contributor. label Oct 6, 2020
@knative-test-reporter-robot
Copy link
Author

Closing issue: this test has passed in latest 2 scans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-and-release Test infrastructure, tests or release auto:flaky kind/good-first-issue Denotes an issue ready for a new contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

No branches or pull requests

3 participants