Fallback to status.domainInternal if not Addressable
#684
Conversation
status.InternalDomain if not Addressablestatus.domainInternal if not Addressable
d74732d to
0d817e0
Compare
status.domainInternal if not Addressablestatus.domainInternal if not Addressable
|
Unfortunately, we haven't picked up the fix from kubernetes/client-go#478 yet, so this test is the same as the other duck-typed tests. Ready for review. Once this is submitted, I'll send a PR to copy the changes to the |
|
The following is the coverage report on pkg/.
|
| if err != nil { | ||
| glog.Warningf("Failed to deserialize legacy target: %s", err) | ||
| return "", err | ||
| if err := duck.FromUnstructured(obj, &t); err == nil { |
There was a problem hiding this comment.
Does this err ever have useful information? If so, we should return it in some form (even if it is part of a larger message).
There was a problem hiding this comment.
This err would either be from obj.MarshallJSON or json.Unmarshall, which would suggest that the object wasn't JSON-able, which would make the "does not contain address" error below accurate.
|
/assign @Harwayne |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #673
Proposed Changes
-Adds an additional fallback in target resolution
Release Note