Start fix for #673

knative · Dec 8, 2018 · d74732d · d74732d
1 parent 7c98bf8
commit d74732d
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/controller/eventing/subscription/reconcile.go b/pkg/controller/eventing/subscription/reconcile.go
@@ -233,6 +233,9 @@ func (r *reconciler) resolveSubscriberSpec(namespace string, s v1alpha1.Subscrib
 	if t.Status.Address != nil {
 		return domainToURL(t.Status.Address.Hostname), nil
 	}
+
+	// TODO: check duckv1alpha1.LegacyTargetable
+
 	return "", fmt.Errorf("status does not contain address")
 }