Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout option to service create #1643

Merged
merged 5 commits into from
Apr 13, 2022
Merged

Add timeout option to service create #1643

merged 5 commits into from
Apr 13, 2022

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Apr 11, 2022

Description

Add --timeout option which will set the field, timeoutInSeconds in service spec.

Changes

  • Added the flag

Reference

Fixes #1181

knative-prow[bot]
knative-prow bot reviewed Apr 11, 2022
View reviewed changes
Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasgun: 0 warnings.

In response to this:

Description

Add --timeout option which will set the field, timeoutInSeconds in service spec.

Changes

  • Added the flag

Reference

Fixes #1181

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2022
@codecov
Copy link

codecov bot commented Apr 11, 2022 •
edited
Loading

Codecov Report

Merging #1643 (3842507) into main (bb7fd73) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
+ Coverage   79.27%   79.28%   +0.01%     
==========================================
  Files         171      171              
  Lines       12906    12914       +8     
==========================================
+ Hits        10231    10239       +8     
  Misses       1955     1955              
  Partials      720      720
Impacted Files Coverage Δ
...kg/kn/commands/service/configuration_edit_flags.go 82.52% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7fd73...3842507. Read the comment docs.

@vyasgun
Copy link
Contributor Author

vyasgun commented Apr 11, 2022

/retest

dsimansk
dsimansk reviewed Apr 11, 2022
View reviewed changes
pkg/serving/config_changes_test.go Outdated
@@ -151,6 +151,17 @@ func TestPinImageToDigestNilContainerStatus(t *testing.T) {
assert.NilError(t, err)
}

func TestPinImageToDigestNilContainerSpec(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test belong to this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there rather be timeout setting tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to improve coverage to prevent the codecov project failure. Removed this test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO adding unit test to cover this flag in create and update operations would help with coverage. Since the common flag doesn't have its own test file, but are rather tested with those ops.

@vyasgun vyasgun force-pushed the pr/default-timeout branch from 1f7fe7b to 1b107cb Compare April 11, 2022 13:04
@dsimansk
Copy link
Contributor

/retest

@vyasgun vyasgun force-pushed the pr/default-timeout branch from 1b107cb to 9b5a9c4 Compare April 12, 2022 18:58
@vyasgun vyasgun force-pushed the pr/default-timeout branch from 158ccab to 184ce4e Compare April 13, 2022 08:50
@vyasgun vyasgun force-pushed the pr/default-timeout branch from cbba583 to 95a1527 Compare April 13, 2022 13:08
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2022
@vyasgun vyasgun force-pushed the pr/default-timeout branch from 95a1527 to 3842507 Compare April 13, 2022 14:00
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 13, 2022
dsimansk
dsimansk approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
@knative-prow knative-prow bot merged commit 0ac405d into knative:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow knative-prow[bot] knative-prow[bot] left review comments

@dsimansk dsimansk dsimansk approved these changes

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kn needs the ability to set a default timeout for the service
2 participants
@vyasgun @dsimansk