Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kn needs the ability to set a default timeout for the service #1181

Closed
Tracked by #1580
utherp0 opened this issue Dec 31, 2020 · 1 comment · Fixed by #1643
Closed
Tracked by #1580

kn needs the ability to set a default timeout for the service #1181

utherp0 opened this issue Dec 31, 2020 · 1 comment · Fixed by #1643
Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request kind/proposal Issues or PRs related to proposals. triage/accepted Issues which should be fixed (post-triage)

Comments

@utherp0
Copy link

utherp0 commented Dec 31, 2020

Feature request

kn create needs a flag for setting the default timeout for the service

Use case

I want to create my services with a default timeout of 10 seconds rather than the standard 300 - currently I can't create a service with the timeout of 10 secs and need to post-create change it (in this case using the OpenShift UI/YAML editor) which creates a new revision

There are flags for most things when creating a service but this one (timeoutSeconds) seems to be missing

/kind proposal

@utherp0 utherp0 added the kind/feature New feature or request label Dec 31, 2020
@knative-prow-robot knative-prow-robot added the kind/proposal Issues or PRs related to proposals. label Dec 31, 2020
@utherp0 utherp0 changed the title kn needs the ability top set a default timeout for the service kn needs the ability to set a default timeout for the service Jan 5, 2021
@navidshaikh navidshaikh added this to the v0.21.0 milestone Jan 19, 2021
@rhuss
Copy link
Contributor

rhuss commented Feb 15, 2021

+1. This is also a good first issue, the option should reflect the yaml field. Note that the name should be also selected that way that it does not get confused with --wait-timeout which is used as a timeout for a blocking wait.

/label good first issue

@navidshaikh navidshaikh modified the milestones: v0.21.0, v0.22.0 Mar 15, 2021
@navidshaikh navidshaikh removed this from the v0.22.0 milestone May 17, 2021
@rhuss rhuss added the triage/accepted Issues which should be fixed (post-triage) label Jul 9, 2021
@rhuss rhuss added the good first issue Denotes an issue ready for a new contributor. label Jan 4, 2022
@rhuss rhuss moved this to Icebox in Client Planning Jan 4, 2022
Repository owner moved this from Backlog to Done in Client Planning Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request kind/proposal Issues or PRs related to proposals. triage/accepted Issues which should be fixed (post-triage)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants