Optimize endpoint index getter and also rename some methods to be mor… #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -330,14 +330,14 @@ func (p *Processor) addNewServicesWithWorkload(workload *workloadapi.Workload, n | |||
| return nil | |||
| } | |||
|
|
|||
| log.Infof("addNewServicesWithWorkload: %v", newServices) | |||
| backend_uid := p.hashName.StrToNum(workload.GetUid()) | |||
| log.Infof("handleWorkloadNewBoundServices %s: %v", workload.Uid, newServices) | |||
kwb0523
reviewed
Aug 28, 2024
kwb0523
reviewed
Aug 28, 2024
| @@ -90,7 +90,7 @@ func (h *HashName) flushDelta(str string, num uint32) error { | |||
| return err | |||
| } | |||
|
|
|||
| func (h *HashName) StrToNum(str string) uint32 { | |||
| func (h *HashName) Hash(str string) uint32 { | |||
There was a problem hiding this comment.
The function name seems a bit abstract and easy to confuse.
There was a problem hiding this comment.
on the contrary, i think this is consistent with go hash pkg
YaoZengzeng
reviewed
Aug 29, 2024
YaoZengzeng
reviewed
Aug 29, 2024
YaoZengzeng
reviewed
Aug 29, 2024
8862597 to
830e9cf
Compare
…e readable Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
830e9cf to
50b4405
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e readable
What type of PR is this?
/kind cleanup
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #775
Previously we iterate all the endpoint map when delete a workload. Now the index are cached in userspace
Special notes for your reviewer:
Does this PR introduce a user-facing change?: