Filter out unhealthy workloads #695
Conversation
Codecov ReportAttention: Patch coverage is
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
8847ebd to
55c5094
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
55c5094 to
c9a3eab
Compare
| @@ -400,6 +400,11 @@ func (p *Processor) handleWorkload(workload *workloadapi.Workload) error { | |||
|
|
|||
| deletedServices, newServices = p.WorkloadCache.AddOrUpdateWorkload(workload) | |||
|
|
|||
| // Exclude the unhealthy workload, which means the workload is not ready | |||
| if workload.Status == workloadapi.WorkloadStatus_UNHEALTHY { | |||
There was a problem hiding this comment.
This is not correct, say if the workload turns to unhealthy from healthy. It will still exist in the bpf map
There was a problem hiding this comment.
This fix depends on some thing in #783, so will continue after that merged
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
c9a3eab to
c5b6f8d
Compare
|
@LiZhenCheng9527 Can you take another look |
|
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #693
Special notes for your reviewer:
Does this PR introduce a user-facing change?: