Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split KeyPress into separate Key and Modifier types. #435

Merged
merged 16 commits into from
Oct 11, 2020

Conversation

gwenn
Copy link
Collaborator

@gwenn gwenn commented Sep 6, 2020

Validate:

  • Pros and cons of tuple struct versus struct ?
  • Tuple struct order: (key, mods) versus (mods, key) ?
  • Remove BackTab and keep only SHIFT-Tab ?
  • Remove Modifiers::CTRL_SHIFT, ... ?
  • Normalize:
    • Ctrl-a => Ctrl-A
    • Shift-A => A

Todo:
\E\E[ sequences on unix (we should use poll).

This PR replaces/enhances:

This PR should fixes:

@gwenn gwenn changed the title Support key modifiers Split KeyPress into separate Key and Modifier types. Sep 7, 2020
@gwenn
Copy link
Collaborator Author

gwenn commented Oct 3, 2020

@fdncred, @thomcc, @bjorn3 would you mind reviewing this PR ?
Only changes in keys.rs and lib.rs are relevant from a user perspective.
Thanks.

@fdncred
Copy link

fdncred commented Oct 7, 2020

@gwenn It looks like progress. I'm anxious to try it out. Looks like we're going to have to change some code, which is fine, assuming it works. :)

@gwenn gwenn merged commit 83999e5 into kkawakam:master Oct 11, 2020
@gwenn gwenn deleted the key_mods branch October 11, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants