Changes to allow Windows backspace keybindings #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2020
gwenn
requested changes
Jul 29, 2020
gwenn
requested changes
Jul 29, 2020
|
I believe I changed all your requested items. Please let me know if you have further feedback. |
gwenn
requested changes
Jul 29, 2020
gwenn
requested changes
Jul 30, 2020
|
@gwenn ping. are we ready to merge this? |
|
I would prefer to fix and merge #333 before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to use
Ctrl+Backspace,Meta+Backspace, andShift+Backspaceas keybindings on Windows. Thanks for your help @gwenn. I figure you'll have changes and not like some of the things I've done. :) I didn't runcargo fmt --allbecause I'm not sure if that's your practice.