-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build libzim on bionic #597
Conversation
@mgautierfr perfect 👍 |
For some reason there is no aarch64-bionic. Or the name hasn't been fixed |
fb6d218
to
70e9dff
Compare
@mgautierfr @rgaudin All good here? Ready to merge? |
Testing the aarch64-bionic from yesterday now |
Unfortunately, this is not working. It looks like it's due to the gcc version used in the cross-compilation toolchain (10.3.0).
@mgautierfr could an earlier version of gcc work? I see a few other options but I don't know what kiwix-build needs and looking at this table it seems like we'd need to go back as far as GCC 8.1.0 to match That would require us to use |
Should be good. I will test. |
Reuse the bionic builder (we should have remove in pr #588) and remove all deps not needed to build libzim.
Update CI to build on native_mixed bionic and build the bionic docker image.
7a8dac8
to
0e53534
Compare
@rgaudin can you try the new aarch64-bionic ? |
Works fine 👍 |
Update CI scripts to build only libzim on native_mixed if os name is bionic.
0e53534
to
fd85b80
Compare
@rgaudin So you approve and we can merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The Draft to non-draft didn't trigger a notification 🤷♂️ |
Fix #595