Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all our CI/CD to focal instead of bionic #588

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Move all our CI/CD to focal instead of bionic #588

merged 4 commits into from
Apr 12, 2023

Conversation

mgautierfr
Copy link
Member

@mgautierfr mgautierfr commented Apr 5, 2023

Bionic is EOL.

Fix #587

@mgautierfr mgautierfr marked this pull request as draft April 5, 2023 13:04
@mgautierfr mgautierfr marked this pull request as ready for review April 5, 2023 14:41
@kelson42
Copy link
Contributor

kelson42 commented Apr 6, 2023

@mgautierfr Don't forget to update the readme

@mgautierfr
Copy link
Member Author

There is nothing on the readme related to that. Or I miss something ?

@kelson42
Copy link
Contributor

kelson42 commented Apr 12, 2023

First line of the README. AFAIK we know secure that our build works on Ubuntu 20.04, not 18.04 anymore.

Otherwise, are we good to merge?

@mgautierfr
Copy link
Member Author

Good catch. I've missed it as it is split in several line (and link in the middle).

Otherwise, are we good to merge?

Yes

LinuxDeployQt check for the libc version to not being to recent.
As we have change the version of libc by moving to focal, we have to
update the version of LinuxDeployQt.
@kelson42 kelson42 changed the title Move all our CI to focal instead of bionic Move all our CI/CD to focal instead of bionic Apr 12, 2023
@kelson42 kelson42 merged commit bfc9294 into main Apr 12, 2023
@kelson42 kelson42 deleted the ubuntu-20.04 branch April 12, 2023 14:54
mgautierfr added a commit that referenced this pull request Apr 19, 2023
Reuse the bionic builder (we should have remove in pr #588) and
remove all deps not needed to build libzim.
mgautierfr added a commit that referenced this pull request Apr 26, 2023
Reuse the bionic builder (we should have remove in pr #588) and
remove all deps not needed to build libzim.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from Ubuntu 18.04 to Ubuntu 20.04 as minimum version supported
2 participants