[R.I.P.] Remove python2legacy and hospython2legacy
#1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - pygame has been removed (one of the purposes of this recipe was to make it work that bootstrap, alongside to be able to target api levels below 21) - the end of life of Python 2 it's near (2020) - we still have the python2 recipe (version 2.7.15) Caveats: - We loose the ability to target api levels below 21 (Android 5.0 - Lollipop)
|
I have no objections to this. I'll merge as soon as I have time to review it, or if others are looking at it then go ahead as far as I'm concerned :) Thanks @opacam |
|
Nice to see it goes 👋 I had to delete the following empty directories:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
Caveats:
See also:
If the code you care about is still on Python 2...the clock is ticking...https://pythonclock.org/
As a side note: I don't think that we can get a green tick mark with this pr in travis...this pr has all the numbers to fail with our
CItestrebuild_updated_recipes...similar than the recently merged pr about the pygame removal